Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Feb 2009 19:46:28 +0000 (UTC)
From:      Ed Schouten <ed@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r188609 - head/sys/dev/usb2/core
Message-ID:  <200902141946.n1EJkS34028690@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ed
Date: Sat Feb 14 19:46:28 2009
New Revision: 188609
URL: http://svn.freebsd.org/changeset/base/188609

Log:
  Remove unneeded execute-permissions from the USB2 device node.
  
  Giving a charactere device execute permissions doesn't have any use.
  Right now there isn't a single device node in /dev that has it, except
  the USB2 device node, so remove it.
  
  Approved by:	hps, thompsa

Modified:
  head/sys/dev/usb2/core/usb2_dev.c

Modified: head/sys/dev/usb2/core/usb2_dev.c
==============================================================================
--- head/sys/dev/usb2/core/usb2_dev.c	Sat Feb 14 18:23:52 2009	(r188608)
+++ head/sys/dev/usb2/core/usb2_dev.c	Sat Feb 14 19:46:28 2009	(r188609)
@@ -1466,13 +1466,13 @@ usb2_dev_init_post(void *arg)
 	 * should never be opened. Therefore a space character is
 	 * appended after the USB device name.
 	 *
-	 * NOTE: The permissions of this device is 0777, because we
+	 * NOTE: The permissions of this device is 0666, because we
 	 * check the permissions again in the open routine against the
-	 * real USB permissions which are not 0777. Else USB access
+	 * real USB permissions which are not 0666. Else USB access
 	 * will be limited to one user and one group.
 	 */
 	usb2_dev = make_dev(&usb2_devsw, 0, UID_ROOT, GID_OPERATOR,
-	    0777, USB_DEVICE_NAME " ");
+	    0666, USB_DEVICE_NAME " ");
 	if (usb2_dev == NULL) {
 		DPRINTFN(0, "Could not create usb bus device!\n");
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902141946.n1EJkS34028690>