Date: Tue, 26 Feb 2008 15:54:25 -0800 (PST) From: Amatus <c11h15no2@yahoo.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: freebsd-gnome@freebsd.org Subject: Re: Question about updating guile to 1.8 Message-ID: <895927.27708.qm@web30003.mail.mud.yahoo.com> In-Reply-To: <1203981656.45899.60.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > On Mon, 2008-02-25 at 14:28 -0800, Amatus wrote: > > --- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > > > > > > > On Mon, 2008-02-25 at 08:38 -0800, Amatus wrote: > > > > --- Joe Marcus Clarke <marcus@marcuscom.com> wrote: > > > > > > > > > The way you're doing it is probably best. The way you > submitted > > > in > > > > > the > > > > > PR, while it may look correct, will most likely break INDEX > when > > > > > guile > > > > > is not installed. Try it. Uninstall guile, then cd to > > > lang/slib, > > > > > and > > > > > run "make describe". Use of != is discouraged for commands > which > > > are > > > > > not in the base system. > > > > > > > > > > Joe > > > > > > > > I uninstalled guile and make describe worked fine with some > noise > > > on > > > > stderr. > > > > > > What output? Any output on stderr is bad. > > > > The "make describe" outputs "/usr/local/bin/guile-config: not > found" on > > stderr as you might expect and the exit code is 0. Since "make > index" > > pipes stdout to the INDEX file everything should work fine, just > some > > uglyness on the user's screen. If it's really important I can try > 2> > > /dev/null in the command or maybe a test -f to see if the file > exists > > first. > > The bigger problem is what happens to the make describe output? If > you > are not trying to use GUILE_VERSION in other make variables, I would > skip the != notation, and use the previous `...` notation as it is > safer. If you use !=, and the make variables that reference > GUILE_VERSION are used to in things like *_DEPENDS, then that will > effectively break INDEX and package builds. > > Joe > I don't understand what the problem is. The "make describe" output on stdout is perfectly fine, the return code is 0, and stderr goes to the user's screen. The != is necessary as far as I can tell for use in PLIST_SUB. Though to get rid of the message on stderr I can do: GUILE_VER!=${TEST} -e ${LOCALBASE}/bin/guile-config && ${LOCALBASE}/bin/guile-config info guileversion | ${CUT} -f 1-2 -d . || : ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?895927.27708.qm>