Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Feb 2024 13:30:29 +0100
From:      Baptiste Daroussin <bapt@nours.eu>
To:        Richard Scheffenegger <rscheff@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   =?US-ASCII?Q?Re=3A_git=3A_c9b6241e250a_-_main_-_?= =?US-ASCII?Q?tcp=3A_address_enum-int-mismatch_?= =?US-ASCII?Q?_fix_gcc13_error_after_f74352fb?= =?US-ASCII?Q?cf15341accaf5a92240871f98323215d?=
Message-ID:  <8136FFC0-33D6-4E57-8835-452A0A4E9A03@nours.eu>
In-Reply-To: <202402251149.41PBnENk086741@gitrepo.freebsd.org>
References:  <202402251149.41PBnENk086741@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
Le 25 février 2024 12:49:14 GMT+01:00, Richard Scheffenegger <rscheff@FreeBSD.org> a écrit :
>The branch main has been updated by rscheff:
>
>URL: https://cgit.FreeBSD.org/src/commit/?id=c9b6241e250a4f1156e2150ccdbad0d3029dcef6
>
>commit c9b6241e250a4f1156e2150ccdbad0d3029dcef6
>Author:     Richard Scheffenegger <rscheff@FreeBSD.org>
>AuthorDate: 2024-02-25 03:45:05 +0000
>Commit:     Richard Scheffenegger <rscheff@FreeBSD.org>
>CommitDate: 2024-02-25 03:46:39 +0000
>
>    tcp: address enum-int-mismatch
>    fix gcc13 error after f74352fbcf15341accaf5a92240871f98323215d
>---
> sys/netinet/cc/cc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/sys/netinet/cc/cc.c b/sys/netinet/cc/cc.c
>index 9308b5f8d764..adcb16e87637 100644
>--- a/sys/netinet/cc/cc.c
>+++ b/sys/netinet/cc/cc.c
>@@ -452,7 +452,7 @@ newreno_cc_after_idle(struct cc_var *ccv)
>  * Perform any necessary tasks before we enter congestion recovery.
>  */
> void
>-newreno_cc_cong_signal(struct cc_var *ccv, uint32_t type)
>+newreno_cc_cong_signal(struct cc_var *ccv, ccsignal_t type)
> {
> 	uint32_t cwin, factor, mss, pipe;
> 

Somehow incremental build has been broken in the last couple of days.

/home/bapt/worktrees/main/sys/netinet/cc/cc.c:475:10: error: 6 enumeration values not handled in switch: 'CC_ACK', 'CC_DUPACK', 'CC_PARTIALACK'... [-Werror,-Wswitch]                                                 475 |         switch (type) {                            |                 ^~~~

This is the error I get since this commit in buildkernel for pkgbase, all arches

Best regards,
Bapt
[-- Attachment #2 --]
<html><head></head><body><div class="gmail_quote"><div dir="auto">Le 25 février 2024 12:49:14 GMT+01:00, Richard Scheffenegger &lt;rscheff@FreeBSD.org&gt; a écrit :</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><div dir="auto">The branch main has been updated by rscheff:<br><br>URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=c9b6241e250a4f1156e2150ccdbad0d3029dcef6">https://cgit.FreeBSD.org/src/commit/?id=c9b6241e250a4f1156e2150ccdbad0d3029dcef6</a><br><br>commit c9b6241e250a4f1156e2150ccdbad0d3029dcef6<br>Author:     Richard Scheffenegger &lt;rscheff@FreeBSD.org&gt;<br>AuthorDate: 2024-02-25 03:45:05 +0000<br>Commit:     Richard Scheffenegger &lt;rscheff@FreeBSD.org&gt;<br>CommitDate: 2024-02-25 03:46:39 +0000<br><br>    tcp: address enum-int-mismatch<br>    fix gcc13 error after f74352fbcf15341accaf5a92240871f98323215d<hr> sys/netinet/cc/cc.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br><br>diff --git a/sys/netinet/cc/cc.c b/sys/netinet/cc/cc.c<br>index 9308b5f8d764..adcb16e87637 100644<br>--- a/sys/netinet/cc/cc.c<br>+++ b/sys/netinet/cc/cc.c<br>@@ -452,7 +452,7 @@ newreno_cc_after_idle(struct cc_var *ccv)<br>  * Perform any necessary tasks before we enter congestion recovery.<br>  */<br> void<br>-newreno_cc_cong_signal(struct cc_var *ccv, uint32_t type)<br>+newreno_cc_cong_signal(struct cc_var *ccv, ccsignal_t type)<br> {<br> 	uint32_t cwin, factor, mss, pipe;<br> <br></div></pre></blockquote></div><br clear="all"><div dir="auto">Somehow incremental build has been broken in the last couple of days.<br><br>/home/bapt/worktrees/main/sys/netinet/cc/cc.c:475:10: error: 6 enumeration values not handled in switch: 'CC_ACK', 'CC_DUPACK', 'CC_PARTIALACK'... [-Werror,-Wswitch]                                                 475 |         switch (type) {                            |                 ^~~~<br><br>This is the error I get since this commit in buildkernel for pkgbase, all arches<br><br>Best regards,<br>Bapt</div></body></html>

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8136FFC0-33D6-4E57-8835-452A0A4E9A03>