Date: Sun, 2 May 2004 19:32:29 +0200 From: Michael Nottebrock <michaelnottebrock@gmx.net> To: obrien@freebsd.org Cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/x11/kdebase3 Makefile pkg-message ports/x11/kdebase3/files pkg-message Message-ID: <200405021932.33696.michaelnottebrock@gmx.net> In-Reply-To: <20040502171345.GA20168@dragon.nuxi.com> References: <200405021310.i42DAoZM055616@repoman.freebsd.org> <20040502171345.GA20168@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sunday 02 May 2004 19:13, David O'Brien wrote:
> On Sun, May 02, 2004 at 06:10:50AM -0700, Michael Nottebrock wrote:
> > lofi 2004/05/02 06:10:50 PDT
> >
> > FreeBSD ports repository
> >
> > Modified files:
> > x11/kdebase3 Makefile
> > Added files:
> > x11/kdebase3/files pkg-message
> > Removed files:
> > x11/kdebase3 pkg-message
> > Log:
> > Process the pkg-message template earlier than post-install so
> > package users will actually get to see it the right way.
> >
> > PR: ports/66123
> > Reported by: obrien
>
> Thank you for fixing this, but why didn't you just leave pkg-message
> where it was? Just because it needs fixing up it doesn't have to live in
> the non-standard files/ directory. Please consider moving that and the
> plists back to the main kdebase3 directory.
I don't think a pkg-message that really isn't one but a template that needs to
be processed first should be visible, so I'd rather hide it in ${FILESDIR}.
Perhaps I should have renamed it to message-template? Also, our plist bits
aren't standard plists (the real plist is concatenated from them, depending
on build options) and thus don't belong into the portdir, but into
${FILESDIR}.
--
,_, | Michael Nottebrock | lofi@freebsd.org
(/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org
\u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBAlTCxXhc68WspdLARAvHwAJ46T3qtBrMm1qcLb9iZxnYWRH6N5ACeLP+Z
vv+RGBn+xZZoqyUNkT+vEGc=
=tXCe
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200405021932.33696.michaelnottebrock>