Date: Fri, 31 Jan 2003 22:30:41 +1100 From: Tim Robbins <tjr@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: current@FreeBSD.org, davidxu@FreeBSD.org, Craig Dooley <cd5697@albany.edu> Subject: Re: Profiling kills -current? Message-ID: <20030131223041.A71698@dilbert.robbins.dropbear.id.au> In-Reply-To: <Pine.NEB.3.96L.1030130161622.26712H-100000@fledge.watson.org>; from rwatson@FreeBSD.org on Thu, Jan 30, 2003 at 04:17:39PM -0500 References: <Pine.NEB.3.96L.1030130161622.26712H-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 30, 2003 at 04:17:39PM -0500, Robert Watson wrote:
> Looks like recent commits may have broken profiling of user applications;
> or rather, it's also causing the kernel to crash. I suspect (but have not
> confirmed) it was the recent KSE commit.
This commit should have fixed the problem causing the system to lock up
when profiling was used. A quick check shows that it's generating reasonable
results now, but I believe that there are other profiling bugs in -current.
==
tjr 2003/01/31 03:22:32 PST
Modified files:
sys/kern subr_trap.c
Log:
Use a local variable to store the number of ticks that elapsed in
kernel mode instead of (unintentionally) using the global `ticks'.
This error completely broke profiling.
Revision Changes Path
1.241 +3 -2 src/sys/kern/subr_trap.c
==
Tim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030131223041.A71698>