Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Mar 2023 16:46:09 GMT
From:      Andrew Turner <andrew@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: bc108947579e - main - Remove an unneeded CTASSERT in the smmu driver
Message-ID:  <202303161646.32GGk9le022234@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by andrew:

URL: https://cgit.FreeBSD.org/src/commit/?id=bc108947579ede209e49dfc38791705aca962fef

commit bc108947579ede209e49dfc38791705aca962fef
Author:     Andrew Turner <andrew@FreeBSD.org>
AuthorDate: 2023-03-16 15:35:04 +0000
Commit:     Andrew Turner <andrew@FreeBSD.org>
CommitDate: 2023-03-16 16:45:42 +0000

    Remove an unneeded CTASSERT in the smmu driver
    
    We don't map the DMAP here
    
    Sponsored by:   Arm Ltd
    Differential Revision:  https://reviews.freebsd.org/D38951
---
 sys/arm64/iommu/iommu_pmap.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sys/arm64/iommu/iommu_pmap.c b/sys/arm64/iommu/iommu_pmap.c
index acef3d8d3368..6319d97ff763 100644
--- a/sys/arm64/iommu/iommu_pmap.c
+++ b/sys/arm64/iommu/iommu_pmap.c
@@ -80,10 +80,6 @@ __FBSDID("$FreeBSD$");
 #define	smmu_l2_index(va)	(((va) >> IOMMU_L2_SHIFT) & IOMMU_Ln_ADDR_MASK)
 #define	smmu_l3_index(va)	(((va) >> IOMMU_L3_SHIFT) & IOMMU_Ln_ADDR_MASK)
 
-/* This code assumes all L1 DMAP entries will be used */
-CTASSERT((DMAP_MIN_ADDRESS  & ~IOMMU_L0_OFFSET) == DMAP_MIN_ADDRESS);
-CTASSERT((DMAP_MAX_ADDRESS  & ~IOMMU_L0_OFFSET) == DMAP_MAX_ADDRESS);
-
 static vm_page_t _pmap_alloc_l3(pmap_t pmap, vm_pindex_t ptepindex);
 static void _smmu_pmap_unwire_l3(pmap_t pmap, vm_offset_t va, vm_page_t m,
     struct spglist *free);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303161646.32GGk9le022234>