Date: Tue, 20 Jan 2009 16:10:16 +0000 From: Dieter <freebsd@sopwith.solgatos.com> To: freebsd-firewire <freebsd-firewire@FreeBSD.org> Subject: Re: Firewire patch Message-ID: <200901210010.AAA00037@sopwith.solgatos.com> In-Reply-To: Your message of "Mon, 19 Jan 2009 19:50:12 PST." <1232423412.8966.2.camel@localhost.localdomain>
next in thread | previous in thread | raw e-mail | index | archive | help
> Hrm ... I don't seem to have sent this to you. Weird. That's ok, I'm subscribed to the -firewire@ list and saw it there. BTW, your ISP doesn't like me so I can't email you off-list. Probably the usual brain dead throw-the-baby-out-with-the-bathwater attempts at spam reduction. > Here is a small-ish patch I'd like to get comitted soon. This removes > the filter implementation of the bus reset interrupt. It moves some > malloc's into a more appropriate area and fixes a potential deadlock in > SBP. > > Take a peak and give it a spin on stable/7 I looked at it, but I don't understand it well enough to count as a code reviewer. I applied this patch to 7.0. (Still waiting for the 7.1 bloatfest to finish downloading...) Patch rejected the FWOHCI_INTFILT stuff, but I think the code does what you want. However I'm not sure what all has changed between 7.0 and whatever bleeding-edge bits you're working with, there could be something significant. Results: The hack to put the NEC controller into non-CYCLEMASTER mode still works, and video plays ok. So it looks like your patch probably doesn't break anything for me. The patch did not fix PR 118093 (bus reset still blocks Ethernet), or PR 113785 (the VIA controller still refuses to go into non-CYCLEMASTER mode). While I had the camcorder plugged into the VIA, I booted the kernel with your previous patch (2008-01-05), but no joy. I wonder if the VIA controller might be faster or slower than the NEC, so fixing the locking might fix PR 113785. If you'd like me to do further testing, such as with 7.1 once I get it installed, and/or I can add my workaround for PR 118093 (change some printfs to log(9)) and leave your patch in and test it for more than a minute or two, let me know.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901210010.AAA00037>