Date: Wed, 30 Apr 2008 04:17:13 -0800 (AKDT) From: Mel <mel@rachie.is-a-geek.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: MAINTAINER <obrien@FreeBSD.org> Subject: ports/123257: [PATCH] vim options does not work as expected Message-ID: <20080430121714.167FF28426@smoochies.rachie.is-a-geek.net> Resent-Message-ID: <200804301240.m3UCe1ee032509@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 123257
>Category: ports
>Synopsis: [PATCH] vim options does not work as expected
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Apr 30 12:40:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Mel
>Release: FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD smoochies.rachie.is-a-geek.net 7.0-STABLE FreeBSD 7.0-STABLE #5: Thu Apr 3 06:42:37 AKDT 2008 root@smoochies.rachie.is-a-geek.net:/usr/obj/usr/src/sys/GENERIC-ULE i386
>Description:
When building vim with WITH_VIM_OPTIONS and not adding *any* gui, the GNOME1
gui is added regardless. There is also no option in the vim options to set
the equivalent of WITHOUT_X11.
>How-To-Repeat:
Set WITH_VIM_OPTIONS in /etc/make.conf, type make config in
/usr/ports/editors/vim, do not check any GUI, including the one advertized as
GNOME1, then type make -V LIB_DEPENDS to see that gtk-1 dep has been added.
Here's the current /var/db/ports/vim/options that demonstrates the case:
# This file is auto-generated by 'make config'.
# No user-servicable parts inside!
# Options for vim-7.1.242
_OPTIONS_READ=vim-7.1.242
WITH_PERL=true
WITHOUT_PYTHON=true
WITHOUT_RUBY=true
WITH_CSCOPE=true
WITHOUT_EXUBERANT_CTAGS=true
WITHOUT_ATHENA=true
WITHOUT_GTK2=true
WITHOUT_GNOME=true
WITHOUT_MOTIF=true
WITHOUT_XTERM_SAVE=true
>Fix:
The hack below implements the correct logic. Really what's needed is 'NO_GUI'
or 'WITHOUT_X11' option in the vim options.
--- editors/vim/Makefile.orig 2008-04-28 15:29:29.000000000 -0800
+++ editors/vim/Makefile 2008-04-30 03:57:52.000000000 -0800
@@ -119,7 +119,7 @@
.if !defined(WITHOUT_X11)
# for now default the GUI to the GTK+ one
# will be reviewed when the GTK+ 1.{3,4} behemoth is released
-.if !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2)
+.if !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2) && !defined(WITHOUT_GNOME)
WITH_GNOME= gtk12
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080430121714.167FF28426>