Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 3 Mar 2015 21:21:43 +0000 (UTC)
From:      Jilles Tjoelker <jilles@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r279569 - head/bin/sh
Message-ID:  <201503032121.t23LLhlq004666@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jilles
Date: Tue Mar  3 21:21:43 2015
New Revision: 279569
URL: https://svnweb.freebsd.org/changeset/base/279569

Log:
  sh: Fix more compiler warnings related to variable declarations.

Modified:
  head/bin/sh/error.c
  head/bin/sh/mknodes.c
  head/bin/sh/mksyntax.c
  head/bin/sh/var.c
  head/bin/sh/var.h

Modified: head/bin/sh/error.c
==============================================================================
--- head/bin/sh/error.c	Tue Mar  3 20:23:59 2015	(r279568)
+++ head/bin/sh/error.c	Tue Mar  3 21:21:43 2015	(r279569)
@@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$");
  */
 
 #include "shell.h"
+#include "eval.h"
 #include "main.h"
 #include "options.h"
 #include "output.h"
@@ -64,7 +65,6 @@ struct jmploc *handler;
 volatile sig_atomic_t exception;
 volatile sig_atomic_t suppressint;
 volatile sig_atomic_t intpending;
-char *commandname;
 
 
 static void exverror(int, const char *, va_list) __printf0like(2, 0) __dead2;

Modified: head/bin/sh/mknodes.c
==============================================================================
--- head/bin/sh/mknodes.c	Tue Mar  3 20:23:59 2015	(r279568)
+++ head/bin/sh/mknodes.c	Tue Mar  3 21:21:43 2015	(r279569)
@@ -204,7 +204,7 @@ parsefield(void)
 }
 
 
-char writer[] = "\
+static const char writer[] = "\
 /*\n\
  * This file was generated by the mknodes program.\n\
  */\n\

Modified: head/bin/sh/mksyntax.c
==============================================================================
--- head/bin/sh/mksyntax.c	Tue Mar  3 20:23:59 2015	(r279568)
+++ head/bin/sh/mksyntax.c	Tue Mar  3 21:21:43 2015	(r279569)
@@ -60,7 +60,7 @@ struct synclass {
 };
 
 /* Syntax classes */
-struct synclass synclass[] = {
+static const struct synclass synclass[] = {
 	{ "CWORD",	"character is nothing special" },
 	{ "CNL",	"newline character" },
 	{ "CBACK",	"a backslash character" },
@@ -85,7 +85,7 @@ struct synclass synclass[] = {
  * Syntax classes for is_ functions.  Warning:  if you add new classes
  * you may have to change the definition of the is_in_name macro.
  */
-struct synclass is_entry[] = {
+static const struct synclass is_entry[] = {
 	{ "ISDIGIT",	"a digit" },
 	{ "ISUPPER",	"an upper case letter" },
 	{ "ISLOWER",	"a lower case letter" },
@@ -94,7 +94,7 @@ struct synclass is_entry[] = {
 	{ NULL, 	NULL }
 };
 
-static char writer[] = "\
+static const char writer[] = "\
 /*\n\
  * This file was generated by the mksyntax program.\n\
  */\n\

Modified: head/bin/sh/var.c
==============================================================================
--- head/bin/sh/var.c	Tue Mar  3 20:23:59 2015	(r279568)
+++ head/bin/sh/var.c	Tue Mar  3 21:21:43 2015	(r279569)
@@ -94,6 +94,7 @@ struct var vps4;
 static struct var voptind;
 struct var vdisvfork;
 
+struct localvar *localvars;
 int forcelocal;
 
 static const struct varinit varinit[] = {

Modified: head/bin/sh/var.h
==============================================================================
--- head/bin/sh/var.h	Tue Mar  3 20:23:59 2015	(r279568)
+++ head/bin/sh/var.h	Tue Mar  3 21:21:43 2015	(r279569)
@@ -68,7 +68,7 @@ struct localvar {
 };
 
 
-struct localvar *localvars;
+extern struct localvar *localvars;
 extern int forcelocal;
 
 extern struct var vifs;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201503032121.t23LLhlq004666>