Date: Tue, 16 Jun 2015 11:50:38 +0200 From: John Marino <freebsd.contact@marino.st> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r389830 - head/cad/ghdl Message-ID: <557FF16E.20706@marino.st> In-Reply-To: <201506160943.t5G9h14w060858@svn.freebsd.org> References: <201506160943.t5G9h14w060858@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/16/2015 11:43, Mathieu Arnold wrote: > Author: mat > Date: Tue Jun 16 09:43:00 2015 > New Revision: 389830 > URL: https://svnweb.freebsd.org/changeset/ports/389830 > > Log: > CLeanup USE_GITHUB usage. > > With hat: portmgr > Sponsored by: Absolight > > Modified: > head/cad/ghdl/Makefile > > Modified: head/cad/ghdl/Makefile > ============================================================================== > --- head/cad/ghdl/Makefile Tue Jun 16 09:36:09 2015 (r389829) > +++ head/cad/ghdl/Makefile Tue Jun 16 09:43:00 2015 (r389830) > @@ -5,7 +5,7 @@ PORTNAME= ghdl > PORTVERSION= 0.32 > PORTREVISION= 2 > CATEGORIES= cad > -DISTFILES= ${SRCDISTFILE} ${GCCDISTFILE} > +DISTFILES= ${DISTNAME}${EXTRACT_SUFX} > > MAINTAINER= marino@FreeBSD.org > COMMENT= GNU VHDL simulator > @@ -26,7 +26,6 @@ GH_TAGNAME= 5adb2f6 > GNU_CONFIGURE= yes > GCCVER= 4.9.2 > LLVMVER= 35 > -SRCDISTFILE= hanzer-${GH_PROJECT}-${PORTVERSION}-${GH_TAGNAME}_GH0.tar.gz > BLD_TARGET= ${ARCH:S/amd64/x86_64/}-portbld-${OPSYS:tl}${OSREL:R} > BUILDDIR= ${WRKDIR}/build > GCCSRCDIR= ${WRKDIR}/gcc-${GCCVER} > @@ -93,7 +92,7 @@ EXTRA_CONFIG+= --with-ld=/usr/bin/ld > EXTRA_CONFIG+= --with-as=${AS_COMMAND} > > .if ${PORT_OPTIONS:MGCC} > -GCCDISTFILE= gcc-${GCCVER}.tar.bz2 > +DISTFILES+= gcc-${GCCVER}.tar.bz2 > USES+= iconv libtool makeinfo perl5 > USE_PERL5= build > INFO= ghdl > It is my understanding that one is not to add DISTFILES, e.g. avoid "DISTFILES+=" due to how Mk/bsd* works. What was wrong with what I had, something I put a LOT of thought into? Also, I hate EXTRACT_SUFX. This wasn't broken, so I think this change was pushing it a bit. I would not have approved it if presented. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?557FF16E.20706>