Date: Sat, 12 Aug 2017 14:45:53 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ryan Libby <rlibby@FreeBSD.org> Cc: Ian Lepore <ian@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r322418 - head/lib/msun/src Message-ID: <5672BE7A-0640-4C8B-9B41-44AD83D7B59E@gmail.com> In-Reply-To: <CAHgpiFwAAs8=pcpuwVCx-hNdPp3OXFESVdZ6=9fJ8kPwZiqVCg@mail.gmail.com> References: <201708112241.v7BMfP5X028262@repo.freebsd.org> <1502555191.47886.30.camel@freebsd.org> <CAHgpiFx=pDQA-dHNQJwqDQ%2B2iXJDkvVNsdmyBZG2EL%2BVJQCU4g@mail.gmail.com> <CAHgpiFwAAs8=pcpuwVCx-hNdPp3OXFESVdZ6=9fJ8kPwZiqVCg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Aug 12, 2017, at 10:55, Ryan Libby <rlibby@FreeBSD.org> wrote:
…
> A few possible quick fixes:
>
> - Change the {arm64,riscv,sparc64}/include/float.h LDBL_MAX_EXP
> definitions from (+16384) to 16384.
>
> - Change HALF_LDBL_MAX from
> #define HALF_LDBL_MAX __CONCAT(__CONCAT(0x0.8p, LDBL_MAX_EXP), L)
> to
> #if LDBL_MAX_EXP != 0x4000
> #error "Unsupported long double format"
> #endif
> #define HALF_LDBL_MAX 0x0.8p16384L
>
> - Change the HALF_LDBL_MAX constant to a variable constructed with
> LD80C(), I think with
> LD80C(0x8000000000000000, 16383, 5.9486574767861588254e+4931L)
> but this also requires #error for LDBL_MAX_EXP != 0x4000, so not
> really any better than the above.
>
> I think I will back the patch out for now and go back to review.
The issue is an inconsistency with how LDBL_MAX_EXP is defined in the MD headers:
$ grep -r LDBL_MAX_EXP sys/sparc64/
sys/sparc64/include/float.h:#define LDBL_MAX_EXP (+16384)
$ grep -r LDBL_MAX_EXP sys/x86/
sys/x86/include/float.h:#define LDBL_MAX_EXP 16384
Cheers,
-Ngie
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJZj3cRAAoJEPWDqSZpMIYVmIwQAMNw+sDbhRARTgI5+idAgLEn
VJQASSEIYpWOJ8TkwoqRRY0oKGMS50thM9NCbHAEb2+6X0FyUbdkuVqj6oUw9qc7
8TjOEJIs2iLUTP2bnVtOdv6FpI3eiT0RljdVVXp9GdOm//JkHx9o7x5ym3VOD9d8
B2B44oJ9avveX217G8rrbTZD5KkyAZYMUDJOF8ir/eMVgpK+51QOgHtCxTVOyCnj
GvrDJuyA6zTzJyx/CHigbLIp3BCLf97MigNZ2N/9w4f5MgYBy0ouOM2+VulcWVpM
GAMM+NkLlAbucb2PgcsrT9YGblREcT7VSJJaqpn2nR7vAEQcEnadHXTvhVUtlK0b
z2UsBz5TE3pOGFzJ0uUD1hMyeGUXf1F3ysSc8TWxfTnu5MF2eE+yOXdkdlJuN9ow
1i9/0XX93jeuJplMr4boS/dymcPJyU0VD9M86HltzNpqda5Wof5CDLgdkvsLNthV
TPVN1ZL2DYvFsk8PwqcITlImTu6EzkzlueGHe4Mvcr3VWWkQccGh0yg8WQMKNw9E
HZuNPw+turGtykjW0/BxgZ/r4vR+eyZ3CCYzXVO/JFRES830+Wn/CpYx/ylzPuF6
50gL/0HlnQ++3VGQv5X4y01EDIUyKW5fC4HZ/Cl6e/OSgFvg5fqktvD4lNUkj9vx
CVMJGelbvypV6YiopWUa
=5zwd
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5672BE7A-0640-4C8B-9B41-44AD83D7B59E>