Date: Wed, 19 Jul 2017 14:00:52 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220548] Mk/Scripts/cargo-crates.awk: "make cargo-crates" doesn't strip branch name Message-ID: <bug-220548-13-4Tn2uS4xnS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-220548-13@https.bugs.freebsd.org/bugzilla/> References: <bug-220548-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220548 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: tobik Date: Wed Jul 19 14:00:17 UTC 2017 New revision: 446198 URL: https://svnweb.freebsd.org/changeset/ports/446198 Log: When specifying Git dependencies in Cargo.toml developers can set 3 additional keys: rev, branch, tag [1]. These are reflected in a projects' Cargo.lock file as e.g. =20 git+https://github.com/servo/angle?branch=3Dservo#a1371e8a160128677af863d1d= 73f150862ba42b2 =20 git+https://github.com/rust-lang/libc?tag=3D0.2.26#288942e6858a4b2f8ee56338= da5386263b9c4b82 Currently cargo-crates.awk generates the wrong output in these cases: GH_TUPLE=3D=20=20=20=20 servo:angle?branch=3Dservo:a1371e8a160128677af863d1d73f150862ba42b2:angle \ =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 rust-lang:libc?tag=3D0.2.26:288942e6858a4b2f8ee56338da5386263b9c4b82:libc Fix cargo-crates.awk to ignore the query string (except in the tag case) and generate GH_TUPLE=3D servo:angle:a1371e8a160128677af863d1d73f150862ba42b2:angl= e \ rust-lang:libc:0.2.26:libc instead. [1] https://github.com/rust-lang/cargo/blob/master/src/doc/specifying-dependenc= ies.md#specifying-dependencies-from-git-repositories PR: 220548 Reported by: jbeich Reviewed by: jbeich, mat Differential Revision: https://reviews.freebsd.org/D11571 Changes: head/Mk/Scripts/cargo-crates.awk --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-220548-13-4Tn2uS4xnS>