Date: Sun, 6 Jun 1999 13:13:45 +0200 (CEST) From: n_hibma@freebsd.org To: FreeBSD-gnats-submit@freebsd.org Subject: misc/12049: [PATCH] searching for closed reports requires two selections Message-ID: <199906061113.NAA44376@elpc36.jrc.it>
next in thread | raw e-mail | index | archive | help
>Number: 12049 >Category: misc >Synopsis: [PATCH] searching for closed reports requires two selections >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jun 6 04:20:00 PDT 1999 >Closed-Date: >Last-Modified: >Originator: Nick Hibma >Release: FreeBSD 4.0-CURRENT i386 >Organization: >Environment: Current web pages at www.freebsd.org http://www.freebsd.org/cgi/query-pr-summary.cgi?query >Description: You can select closed in the 'State:' field, but if you want to actually see the closed ones you have to select the button 'Closed reports too' at the bottom of the page. I suggest moving that button up to below the State: field. Maybe rename the button to 'Show closed reports too'. Other option is to include Closed reports automatically if someone asks for state 'Closed'. Both patches are included. Use the chunk you like. >How-To-Repeat: >Fix: n_hibma@freefall:cgi% cvs diff query-pr-summary.cgi Index: query-pr-summary.cgi =================================================================== RCS file: /home/ncvs/www/en/cgi/query-pr-summary.cgi,v retrieving revision 1.22 diff -u -r1.22 query-pr-summary.cgi --- query-pr-summary.cgi 1999/02/26 22:05:58 1.22 +++ query-pr-summary.cgi 1999/06/06 11:13:37 @@ -203,7 +203,8 @@ # [--list-categories] [--list-responsible] [--list-submitters] # [--text=text] [--multitext=mtext] [PR] [PR]... -$query_args .= " --skip-closed" unless $input{"closedtoo"}; +$query_args .= " --skip-closed" + unless $input{"closedtoo"} or $input{"state"} eq "closed"; # Only read the appropriate PR's. foreach ("category", "originator", "priority", "class", "responsible", @@ -509,7 +510,6 @@ <OPTION VALUE="analyzed">Analyzed</OPTION> <OPTION VALUE="feedback">Feedback</OPTION> <OPTION VALUE="suspended">Suspended</OPTION> -<OPTION VALUE="closed">Closed</OPTION> </SELECT></TD> <TD><B>Sort by</B>:</TD> <TD><SELECT NAME="sort"> @@ -519,6 +519,9 @@ <OPTION VALUE="responsible">Responsible Party</OPTION> </SELECT></TD> </TR><TR> +<TD><B>Closed reports too</B>:</TD> +<TD><INPUT NAME="closedtoo" TYPE=CHECKBOX></TD> +</TR><TR> <!-- We don't use submitter Submitter: --> <TD><B>Text in single-line fields</B>:</TD> <TD><INPUT TYPE=TEXT NAME="text"></TD> @@ -529,9 +532,6 @@ <TD><INPUT TYPE=TEXT NAME="multitext"></TD> <TD><B>Originator</B>:</TD> <TD><INPUT TYPE=TEXT NAME="originator"></TD> -</TR><TR> -<TD><B>Closed reports too</B>:</TD> -<TD><INPUT NAME="closedtoo" TYPE=CHECKBOX></TD> </TR> </TABLE> <INPUT TYPE="SUBMIT" VALUE=" Query PR's "> >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199906061113.NAA44376>