Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Nov 2016 17:56:18 +0100
From:      Torsten Zuehlsdorff <tz@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r427434 - in head/net-im: . pecl-stomp2
Message-ID:  <ae4a6f8a-b9eb-edea-cd0c-25b5000feedc@FreeBSD.org>
In-Reply-To: <eeb117d2-ae51-fdb5-d0ff-32b0c17c8e39@FreeBSD.org>
References:  <201611301617.uAUGHwsP016651@repo.freebsd.org> <f3f6852e-ea1e-1338-cb03-4e25b0b8c727@FreeBSD.org> <29015284-f5ea-1f84-9fa6-482a223f8c7e@FreeBSD.org> <eeb117d2-ae51-fdb5-d0ff-32b0c17c8e39@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help


On 30.11.2016 17:38, Mathieu Arnold wrote:
> Le 30/11/2016 à 17:31, Torsten Zuehlsdorff a écrit :
>>
>>
>> On 30.11.2016 17:25, Mathieu Arnold wrote:
>>> Le 30/11/2016 à 17:17, Torsten Zuehlsdorff a écrit :
>>>> +PHP_VER=    70
>>>
>>> This port is not named phpXX-something, you cannot use PHP_VER in it.
>>
>> php70-* ports are nearly all PHP modules. But this is a port of an
>> pecl-extension, which builds just against PHP 7.0 (and 7.1) and become
>> a PHP module. But also build many pecl portsagainst multiple versions
>> of PHP.
>
> If it is not PHP 7.0 specific but also works for PHP 7.1, then you must
> not set PHP_VER.
> It will not build if the default PHP is not 7.0, but it is a good thing,
> because someone installing php 5.6 stuff and then asking for pecl-stomp2
> will get php 7.0 installed and php 5.6 removed.

Done, thanks for the clarification!

>> So what would be a better name? php70-pecl-stomp2? Do i need to
>> duplicate it later into php71-pecl-stomp2? Or shut i just remove the
>> PHP_VER?
>
> Remove the PHP_VER line.
>
> (Side not, PHP 5.5 does not exist any more.)

Dropped it together with PHP_VER.

Greetings,
Torsten




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ae4a6f8a-b9eb-edea-cd0c-25b5000feedc>