Date: Thu, 9 Jun 2016 14:43:04 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Warner Losh <wlosh@bsdimp.com> Cc: Emmanuel Vadot <manu@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301714 - head/sys/boot/efi/libefi Message-ID: <20160609144304.05437ef3d7f2fe9cd26704ac@bidouilliste.com> In-Reply-To: <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> References: <201606090202.u5922pwl024436@repo.freebsd.org> <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I wanted to more verbose in case of the system don't have partition o n disk (or the EFI implementation only support raw disks like U-Boot) but this might be a bad way of doing saw, I didn't think about the implication you're talking about. I'll try to figure a better way to do this. On Wed, 8 Jun 2016 22:21:36 -0400 Warner Losh <wlosh@bsdimp.com> wrote: >=20 > > On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot <manu@FreeBSD.org> wrote: > >=20 > > Author: manu > > Date: Thu Jun 9 02:02:50 2016 > > New Revision: 301714 > > URL: https://svnweb.freebsd.org/changeset/base/301714 > >=20 > > Log: > > Print a message when the efi disk isn't a logical partition. >=20 > Why on earth would you do that? This will print a message, one per full d= isk, and our systems have 36 disks in them? > Please consider backing this out... >=20 > Warner >=20 >=20 > > Approved by: andrew (mentor) > > Differential Revision: https://reviews.freebsd.org/D6782 > >=20 > > Modified: > > head/sys/boot/efi/libefi/efipart.c > >=20 > > Modified: head/sys/boot/efi/libefi/efipart.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 (r30171= 3) > > +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 (r30171= 4) > > @@ -119,8 +119,11 @@ efipart_init(void)=20 > > (void**)&blkio); > > if (EFI_ERROR(status)) > > continue; > > - if (!blkio->Media->LogicalPartition) > > + if (!blkio->Media->LogicalPartition) { > > + printf("%s%d isn't a logical partition, skipping\n", > > + efipart_dev.dv_name, n); > > continue; > > + } > >=20 > > /* > > * If we come across a logical partition of subtype CDROM > >=20 --=20 Emmanuel Vadot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160609144304.05437ef3d7f2fe9cd26704ac>