Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Dec 2005 00:05:14 -0600
From:      "Jeremy Messenger" <mezz7@cox.net>
To:        "Edwin Groothuis" <edwin@mavetju.org>
Cc:        cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/graphics/librsvg2 Makefile
Message-ID:  <op.s2i660pg9aq2h7@mezz.mezzweb.com>
In-Reply-To: <op.s2i6xpm59aq2h7@mezz.mezzweb.com>
References:  <200512290138.jBT1cREu093693@repoman.freebsd.org> <op.s2i51hlq9aq2h7@mezz.mezzweb.com> <20051229054645.GG3805@k7.mavetju> <op.s2i6xpm59aq2h7@mezz.mezzweb.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 28 Dec 2005 23:59:39 -0600, Jeremy Messenger <mezz7@cox.net> wrote:

> On Wed, 28 Dec 2005 23:46:45 -0600, Edwin Groothuis <edwin@mavetju.org>  
> wrote:
>
>> On Wed, Dec 28, 2005 at 11:40:19PM -0600, Jeremy Messenger wrote:
>>> On Wed, 28 Dec 2005 19:38:27 -0600, Edwin Groothuis <edwin@FreeBSD.org>
>>> wrote:
>>>
>>> >edwin       2005-12-29 01:38:27 UTC
>>> >
>>> >  FreeBSD ports repository
>>> >
>>> >  Modified files:
>>> >    graphics/librsvg2    Makefile
>>> >  Log:
>>> >  [PATCH] allows graphics/librsvg2 to build on 4.11
>>> >         patch allows graphics/librsvg2 to build on 4.11
>>> >          by disabling MOZILLA_PLUGIN option for
>>> >          FreeBSD < 5.0
>>> > PR:             ports/90410
>>> >  Submitted by:   Michael C. Shultz <ringworm01@gmail.com>
>>> >  Approved by:    maintainer timeout
>>>
>>> If you want to do the maintainer timeout, can you please test it first
>>> before you commit it? Now it broke the build. I backed out to  
>>> Makefile,v
>>> 1.48 by myself and I can build it again.
>>
>> [..]
>> ==>   Compressing manual pages for librsvg2-2.12.7_3
>> ===>   Running ldconfig
>> /sbin/ldconfig -m /usr/X11R6/lib
>> ===>   Registering installation for librsvg2-2.12.7_3
>> ===>  Building package for librsvg2-2.12.7_3
>> Creating package /tmp/packages/All/librsvg2-2.12.7_3.tgz
>> Registering depends: libgsf-1.13.3 gtk-engines2-2.6.6_1 gconf2-2.12.1  
>> gtk-2.8.9 atk-1.10.3 pango-1.10.2 gnomehier-2.0_7  
>> XFree86-fontScalable-4.5.0 ORBit2-2.12.4_1 hicolor-icon-theme-0.5  
>> libIDL-0.8.6_1 libcroco-0.6.0_2 bitstream-vera-1.10_2 libXft-2.1.7  
>> cairo-1.0.2_1 XFree86-fontEncodings-4.5.0 linc-1.0.3_4 tiff-3.7.4  
>> shared-mime-info-0.16_2 XFree86-libraries-4.5.0 libart_lgpl2-2.3.17  
>> popt-1.7 fontconfig-2.3.2,1 libxml2-2.6.22 glib-2.8.4 gettext-0.14.5  
>> freetype2-2.1.10_2 pkgconfig-0.20 png-1.2.8_2 libiconv-1.9.2_1  
>> expat-1.95.8_3 jpeg-6b_3.
>> Creating gzip'd tar ball in '/tmp/packages/All/librsvg2-2.12.7_3.tgz'
>>
>> Please give me some more information as which OS version and friends.
>
> 6.0-STABLE, looks like this new change is causing mozilla plugins to be  
> always enable. This part below is in the wrong place.
>
> CONFIGURE_ARGS+=--enable-mozilla-plugin=no
>
> Before:
> ==================================
> # make configure
> ===>  Extracting for librsvg2-2.12.7_2
> => MD5 Checksum OK for gnome2/librsvg-2.12.7.tar.bz2.
> [...]
>          Build GdkPixbuf loader:         yes
>          Build theme engine:             yes
>          Build Netscape plugin:          no <-- here.
> ==================================
>
> After:
> ==================================
> # make configure
> ===>  Extracting for librsvg2-2.12.7_3
> => MD5 Checksum OK for gnome2/librsvg-2.12.7.tar.bz2.
> [...]
>          Build GdkPixbuf loader:         yes
>          Build theme engine:             yes
>          Build Netscape plugin:          yes <-- here, even there is no  
> mozilla dependency in the 'make depends'.
> ==================================
>
> I think, the mozilla plugins might be complete broke or maybe not. I  
> haven't dig in it yet.

Okay, the mozilla plugins isn't complete broke. I just have to do is to  
use WITH_MOZILLA_PLUGIN=yes to pass the build because of post-patch. The  
new change is forcing me to enable mozilla plugins to pass the build when  
I have Mozilla and Firefox installed, which I don't want to have plugins  
enable.

Cheers,
Mezz

> Really, I don't see there is any point to have this plugins option when  
> Mozilla/Firefox have their own SVG stuff thought. Maybe I am missing  
> something for understand why librsvg has plugins option.
>
> Cheers,
> Mezz
>
>> Edwin


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.s2i660pg9aq2h7>