Date: Tue, 20 May 2008 12:09:11 +1200 From: Andrew Thompson <thompsa@FreeBSD.org> To: Pietro Cerutti <gahr@FreeBSD.org> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Problem since "wlan" came in: SIOCS80211: Device not configured Message-ID: <20080520000911.GA46085@citylink.fud.org.nz> In-Reply-To: <483210CC.5070309@FreeBSD.org> References: <48317B44.1080909@FreeBSD.org> <20080519131325.GC55052@rink.nu> <48317ED8.3030904@FreeBSD.org> <4831B2D3.3080600@freebsd.org> <20080519231726.GA44361@citylink.fud.org.nz> <483210CC.5070309@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--MGYHOYXEY6WxJCY8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Tue, May 20, 2008 at 01:44:12AM +0200, Pietro Cerutti wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
> |
> | I have looked at this, I believe the error case in this situation is
> | that the vap is running but the taskq to init the parent has not
> | completed yet. The scan checks the parents status before auctioning it.
> |
> | Can you see if this fixes it. I am not sure its the correct approach but
> | will at least confirm the fault.
>
> For which definition of 'this'? ;-)
That was a test, you passed. Try this patch.
--MGYHOYXEY6WxJCY8
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="vapioctl.diff"
Index: ieee80211_ioctl.c
===================================================================
RCS file: /home/ncvs/src/sys/net80211/ieee80211_ioctl.c,v
retrieving revision 1.60
diff -u -p -r1.60 ieee80211_ioctl.c
--- ieee80211_ioctl.c 11 May 2008 23:36:58 -0000 1.60
+++ ieee80211_ioctl.c 19 May 2008 23:03:47 -0000
@@ -3123,7 +3123,7 @@ ieee80211_ioctl(struct ifnet *ifp, u_lon
{
struct ieee80211vap *vap;
struct ieee80211com *ic;
- int error = 0;
+ int error = 0, n;
struct ifreq *ifr;
struct ifaddr *ifa; /* XXX */
@@ -3164,6 +3164,11 @@ ieee80211_ioctl(struct ifnet *ifp, u_lon
ieee80211_stop_locked(vap);
}
IEEE80211_UNLOCK(ic);
+ /* Wait for the parent to initialise if the vap has been UP'd */
+ n = 50;
+ while (n-- && (ic->ic_ifp->if_flags & IFF_UP) &&
+ !(ic->ic_ifp->if_drv_flags & IFF_DRV_RUNNING))
+ pause("vapioctl", hz/10);
break;
case SIOCADDMULTI:
case SIOCDELMULTI:
--MGYHOYXEY6WxJCY8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080520000911.GA46085>