Date: Mon, 15 Jul 2019 19:54:35 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238730] r349985 on ppc64 IBM 970MP PowerMac G5 possible panic in bus_generic_new_pass Message-ID: <bug-238730-227-lTt68vMB1P@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238730-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238730 --- Comment #16 from Andriy Gapon <avg@FreeBSD.org> --- (In reply to Dennis Clarke from comment #13) It's been a while since I last saw a context diff, unified diffs are all rage now :) I think that the diff does not do what I asked in comment #12. It moves an assignment not the check. This is what I meant: Index: sys/dev/bge/if_bge.c =================================================================== --- sys/dev/bge/if_bge.c (revision 349883) +++ sys/dev/bge/if_bge.c (working copy) @@ -3276,6 +3276,8 @@ bge_mbox_reorder(struct bge_softc *sc) bus = device_get_parent(dev); if (device_get_devclass(dev) != pcib) break; + if (device_get_devclass(bus) != pci) + break; for (i = 0; i < nitems(mbox_reorder_lists); i++) { if (pci_get_vendor(dev) == mbox_reorder_lists[i].vendor && @@ -3287,8 +3289,6 @@ bge_mbox_reorder(struct bge_softc *sc) return (1); } } - if (device_get_devclass(bus) != pci) - break; } return (0); } -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238730-227-lTt68vMB1P>