Date: Wed, 12 Feb 2020 10:33:54 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: powerpc@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r525704 - head/math/hmat-oss Message-ID: <20200212093354.GA81619@KGPE-D16> In-Reply-To: <alpine.LSU.2.21.2002120045231.5016@anthias.pfeifer.com> References: <202002101323.01ADNuln021504@repo.freebsd.org> <alpine.LSU.2.21.2002120045231.5016@anthias.pfeifer.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
The only supported FreeBSD version that doesn't support OpenMP is 12.0 with Clang and it's soon going EOL.
This means that all supported releases will soon have OpenMP supported by base compiler (either by GCC or Clang) and USES=compiler:openmp may then be removed. All occurences of: .if ${CHOSEN_COMPILER_TYPE} == gcc USE_GCC=yes should then be converted to just USES=compiler:c11.
So IMO there's little point in your change now that 12.0 EOL is in over 2 weeks.
On 20-02-12 01:01:25, Gerald Pfeifer wrote:
> [ adding powerpc@ ]
>
> On Mon, 10 Feb 2020, Piotr Kubaj wrote:
> > Log:
> > math/hmat-oss: fix build on GCC architectures
> >
> > After OpenBLAS update, new GCC is required:
> > CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
> > Could NOT find CBLAS (missing: CBLAS_LIBRARIES)
> :
> > +.if ${CHOSEN_COMPILER_TYPE} == gcc
> > +USE_GCC= yes
> > +.endif
>
> This made me realize something bizarre: Mk/Uses/compiler.mk has
>
> .if ${_COMPILER_ARGS:Mopenmp}
> .if ${COMPILER_TYPE} == clang
> USE_GCC= yes
> CHOSEN_COMPILER_TYPE= gcc
> .endif
> .endif
>
> If I read this correctly, on platforms with GCC as the system compiler
> this means the rotten GCC 4.2 is used for something new and evolving
> like OpenMP?
>
> Really, OpenMP should imply USE_GCC=yes instead of even trying to
> rely on GCC 4.2. That would save you the effort of having to make
> such changes one by one and also simplify the ports tree.
>
> *And* it would align powerpc* more closely with i386/amd64 by using
> the same compiler for such ports.
>
> I'll be happy to prepare a patch for Mk/Uses/compiler.mk, but we'd
> need you (and/or other powerpc* folks) to give it a try and adjust
> things if necessary. Would you like to?
>
> Gerald
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl5DxoEACgkQelmbhSCD
nJ2ybw//e1KPfz51AMMO4sq+IzAIen81iNTqWnbIgqo08J3f6p1eG9YuCRSep31K
yfZjbzx6Q7bhGeWOhYVWWhwaHDX2R8KiS5vJqpMtQETxA0YKk64nZdKxE8SYp/WY
LkuVmfZUnhVi4BDqCIGhzoxgXzUhVLnfYK1wisx4gMfVdrsG5gXtCDrcRE4fW70L
iupwl7Qf3pDvDO30SYPnZnhH6HQxS5mgC7R53lOaTaxALwCl5NbmF/pwkFYw/cKO
CuRLi5MrSHT/yQhcPyGJT0XRK5LaDXdtVcmnAB1e93YGMNkgixscczZE4tYZzXhf
0gCRfZ6/GDtV/lyZtxEmLZdbxXvAoIPcyi3vCTkYEfcKDHVM4MBpzIEzNNbiD35Y
d/3m7RHWlSadeMaMD39YedC9agYOXkZ67f7IQT3PxHRZLSd39t0KpsQEO3CBVYzB
dxPBJiKHKY3Q8NHkwFFQJSiwS8kiwjiSDWHZDSg9rDDhgjVxX8y2bo3BqX3nBaaY
buD9pnwTfD44AyS9hVl+PdtOyvMpIHAYTHGx14KQwX8FMK+jqA5rV4K6aZNSek3/
FdyFphQE/6yElscDMlFtGHnPrrzWW3Ckx5IxW7/ksGwCoaxVaPvriQ+IybMGNoIL
AoFJZpCT/ruivFtE6HCU/OhYoB0BzkjvSXq5JIjAOV+bQq7oMmk=
=PMoA
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200212093354.GA81619>