Date: 26 Jun 2002 23:59:09 +0200 From: Dag-Erling Smorgrav <des@ofug.org> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh-portable session.c Message-ID: <xzpznxh1z2q.fsf@flood.ping.uio.no> In-Reply-To: <20020626152357.GA30110@nagual.pp.ru> References: <200206261417.g5QEHTjR074759@freefall.freebsd.org> <20020626152357.GA30110@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
"Andrey A. Chernov" <ache@nagual.pp.ru> writes: > About PATH: it seems that you expect that setusercontext() will set it, > but setusercontext() can fail (its return code currently not checked, but > was checked in our old code). It leaves code flow with no PATH. Better to > set PATH before it & check its return code too. I am not sure about > failure reaction, it can be fatal or just warning. Yes, that's a good point. The original code also assumes setusercontext(3) will succeed, and copies the parent's PATH to the child - but if setusercontext(3) failed, PATH might be anything (what if sshd was started manually from a shell?) It should use a compiled-in fallback instead. > About TERM: see "term" variable in login.conf(5) - sshd must not override > it and follow the way login does. I disagree. The "term" variable is a fallback. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpznxh1z2q.fsf>