Date: Wed, 4 Feb 2026 19:02:00 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Abdelkader Boudih <freebsd@seuros.com>, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Message-ID: <25B2F11A-19F2-452E-971E-3C2C953540C5@gmail.com> In-Reply-To: <aYO3fobNQFFsYuAo@kib.kiev.ua> References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <aYGIvC3v0zQCJrGo@kib.kiev.ua> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> <aYGqHESSZPxYL9QZ@kib.kiev.ua> <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> <aYHQQO61CR_DxCbQ@kib.kiev.ua> <F0F80955-2AA1-464A-914B-8B602D4D79A9@gmail.com> <aYO3fobNQFFsYuAo@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Feb 4, 2026, at 1:17 PM, Konstantin Belousov <kostikbel@gmail.com> wrote: > > On Tue, Feb 03, 2026 at 10:25:27PM -0800, Enji Cooper (yaneurabeya) wrote: >> >>> On Feb 3, 2026, at 2:38 AM, Konstantin Belousov <kostikbel@gmail.com> wrote: >>> >>> On Tue, Feb 03, 2026 at 11:08:40AM +0100, Abdelkader Boudih wrote: >>>> I agree that this should not be permanent verbosity. >>>> >>>> The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models. >>>> >>>> I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code. >> >> One sidenote: this is hidden behind bootverbose: it’s not always being displayed. >> >> I think it’s fine making the message more terse. It might clarify behavior on Apple platforms since the added behavior contradicts other OSI-related behavior and can result in a POLA violation. > > Can you fix it, please, instead thinking that it might be fine? Done: https://cgit.freebsd.org/src/commit/?id=9c666de5b339d3c8f9bf3963691e4310e7d159cb -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmECCgACgkQGpE5DjPs NJgDuhAAm6asA+jCvHoSEtUe/5LRYUFhuEHgDPqXJfsshMOEm0qDcSAdO3HpKtte yJ2qHRr0FY2GwXaQAViEjZIgRNpKeDxqntvo62uerPN+oQrGMCPxfUsrRvtvuw3a dthP4SFZemIgSt85kGLeihKrxcvsUArkIi8mW6ertT42AaYOyqShc8uwAColamDC 01d2hW5d9DXVLph4fkUdjWOZosb61PTV0KAWC69Aqe81eIFhKq2lL/tB7V54M6xX nV3eAD/FITMz35ZtR6ih9p/3Mb0Rtx/h6TZSlyWOb1SS1YWI/h2L9znpGf+eEGgx NVacL08K7+4JGJcUFFcoYzyX91DRicvqLR02LMtV0n4bqKfY5wZf9S4q2vC5UX1t 3c7dyik/duqJSnqH2nT+bkzAXun3pHV3agLzRctDz1DEemCzUzLDuiZwFtbL6eJZ l53sd2No3wEn9dbqp6cv/LIaYAFHGWkmrrB1Kyxfcu/zdGcmh6M6v9FKpELNzqXD KEI1kk8WCLZcwEUxavAZY3a0teWs7cdsqgbqKUlSiQR+A+PWNaAoKBAH36xsfQql YWTbT5ZpkEh/dlTh6wLsRaWXAD9thj0eQt3ZFZL1uNcOgUSEshpdHngB59u7Ztaw xNwi6PgLGfsvrsp7SZKAlk1CdTTJhsHvMOV/+xydrs6QLSwY6CU= =rXNN -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25B2F11A-19F2-452E-971E-3C2C953540C5>