Date: Thu, 1 Oct 2020 16:25:26 -0500 From: Kyle Evans <kevans@freebsd.org> To: Moritz Schmitt <moritz@schmi.tt> Cc: ports-list freebsd <freebsd-ports@freebsd.org> Subject: Re: Patch compiler warnings away? Message-ID: <CACNAnaE%2BGLfySidp5njR1=EjrDY5RocmOZOQK6p2gu02NSSfRQ@mail.gmail.com> In-Reply-To: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt> References: <20201001211149.uhdi4w6xstjv4iw3@t470.schmi.tt>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 1, 2020 at 4:12 PM Moritz Schmitt <moritz@schmi.tt> wrote: > > Hi, > > I recently took over my first maintainership of a port and I have a > question regarding on how to deal with compiler warnings. > > The port is devel/cscope and it seems to be in a rather good shape. It > contains the newest version of cscope and it builds without any major > problems. However, when building it the compiler issues three warnings > that I could easily patch away. > > What's the recommended approach? Just ignore the warnings and don't > modify the software since it builds anyway? Or create patches even > though they don't seem to be strictly necessary? > > In any case, I will send the patches to the project in the hope that > they fix it upstream in the long run. > This is kind of your prerogative as the maintainer to do whatever you feel is right. Personally, I would usually not bother patching the port if I can easily send it upstream and they don't look like actual functional/security issues, *unless* I'm doing a version update anyways that would cause folks to rebuild the port -- then I might tack them on at the same time just so I can later point to the port and say "Hey, we've been running with these and everything is (fine / on fire)!" In any event, +1 for sending them upstream regardless. :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaE%2BGLfySidp5njR1=EjrDY5RocmOZOQK6p2gu02NSSfRQ>