Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 Sep 2021 18:28:53 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6352bbf7be9b - main - vmem: disable debug.vmem_check by default
Message-ID:  <202109021828.182ISr0W070383@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=6352bbf7be9b312979a4110342ff4e18eb0fcfa4

commit 6352bbf7be9b312979a4110342ff4e18eb0fcfa4
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-09-02 09:49:39 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2021-09-02 18:28:45 +0000

    vmem: disable debug.vmem_check by default
    
    It has a prohibitive performance impact when running real workloads.
    
    Note this only affects kernels with DIAGNOSTIC.
    
    Reviewed by:    markj
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    Differential Revision:  https://reviews.freebsd.org/D31784
---
 sys/kern/subr_vmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/kern/subr_vmem.c b/sys/kern/subr_vmem.c
index dfc9c3b9bf74..74684ff1b2d5 100644
--- a/sys/kern/subr_vmem.c
+++ b/sys/kern/subr_vmem.c
@@ -181,7 +181,7 @@ struct vmem {
 #define	BT_END(bt)	((bt)->bt_start + (bt)->bt_size - 1)
 
 #if defined(DIAGNOSTIC)
-static int enable_vmem_check = 1;
+static int enable_vmem_check = 0;
 SYSCTL_INT(_debug, OID_AUTO, vmem_check, CTLFLAG_RWTUN,
     &enable_vmem_check, 0, "Enable vmem check");
 static void vmem_check(vmem_t *);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109021828.182ISr0W070383>