Date: Mon, 8 Jan 2018 12:11:44 +0100 From: Miroslav Lachman <000.fbsd@quip.cz> To: Eugene Grosbein <eugen@grosbein.net>, Michael Grimm <trashcan@ellael.org>, freebsd-ports@freebsd.org Subject: Re: 'pkg upgrade -f spamassassin' stops but doesn't restart spamd Message-ID: <5A5351F0.7050804@quip.cz> In-Reply-To: <5A528D36.4020409@grosbein.net> References: <76627A89-D7E9-4010-910B-5F25886E7E7E@ellael.org> <5A523873.2050001@quip.cz> <5A524855.2040901@grosbein.net> <5A5284CC.9050400@quip.cz> <5A528749.9070308@grosbein.net> <5A528A87.4050908@quip.cz> <5A528D36.4020409@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Eugene Grosbein wrote on 01/07/2018 22:12:
> 08.01.2018 4:00, Miroslav Lachman wrote:
>
>> PRs are false alibi. Some of my PRs are open for more than 10 years.
>
> So were mine when I could not commit fixes myself. This is not excuse to be lazy and not make another one.
>
>> For all erroneous port there must be will on maintainer and committer side.
>> And if "they" think this is not a bug
>
> If we have written policy (and we have in this case), and upgrade really break things,
> sane committer will not think "this is not a bug".
>
> Again, do you have a PR with "how-to-repeat" scenario and a patch,
> so I could take it?
OK, let's move on. I can open PR if you are willing to help and commit
some fixes. But can we first talk about what and how should be done?
What is the right way to handle Apache module install / deinstall /
upgrade? Because some modules are using code from Mk/bsd.apache.mk which
do the wrong thing:
.if defined(AP_FAST_BUILD)
.if !target(ap-gen-plist)
_USES_build+= 490:ap-gen-plist
ap-gen-plist:
.if defined(AP_GENPLIST)
. if !exists(${PLIST})
@${ECHO} "===> Generating apache plist"
@${ECHO} "%%APACHEMODDIR%%/%%AP_MODULE%%" >> ${PLIST}
@${ECHO} "@postexec %D/sbin/apxs -e ${AP_MOD_EN} -n %%AP_NAME%%
%D/%F" >> ${PLIST}
@${ECHO} "@postunexec ${SED} -i '' -E
'/LoadModule[[:blank:]]+%%AP_NAME%%_module/d'
%D/%%APACHEETCDIR%%/httpd.conf" >> ${PLIST}
@${ECHO} "@postunexec echo \"Don't forget to remove all
${MODULENAME}-related directives in your httpd.conf\"">> ${PLIST}
. endif
.endif
.endif
Some modules did similar thing in Makefile (or they did in the past).
1) Should install put something in to httpd.conf?
2) Should deinstall or upgrade remove something from httpd.conf?
3) Or as I suggested here
https://lists.freebsd.org/pipermail/freebsd-ports/2017-October/110725.html
should each module install own sample file in apache24/modules.d/?
Miroslav Lachman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5A5351F0.7050804>