Date: Sun, 21 Mar 2004 15:45:28 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Matthew N. Dodd" <mdodd@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_arcsubr.c Message-ID: <20040321144528.GF8930@darkness.comp.waw.pl> In-Reply-To: <200403210634.i2L6YYj4087193@repoman.freebsd.org> References: <200403210634.i2L6YYj4087193@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Mar 20, 2004 at 10:34:34PM -0800, Matthew N. Dodd wrote:
+> mdodd 2004/03/20 22:34:34 PST
+>
+> FreeBSD src repository
+>
+> Modified files:
+> sys/net if_arcsubr.c
+> Log:
+> Handle AF_ARP.
[...]
+> + switch(ntohs(ah->ar_op)) {
+> + case ARPOP_REVREQUEST:
+> + case ARPOP_REVREPLY:
+> + type = htons(ARCTYPE_REVARP);
+> + break;
+> + case ARPOP_REQUEST:
+> + case ARPOP_REPLY:
+> + default:
+> + type = htons(ARCTYPE_ARP);
+> + break;
+> + }
[...]
Tinderbox is reporting failures, probably because you planned to use
'atype' here, instead of 'type', but I don't want to fix it, because I
don't understand this: 'atype' is a u_int8_t, so I think htons() will
transform in to '0' on some archs (e.g. i386) and I don't think it
was your intention.
--
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAXaqIForvXbEpPzQRAhysAKC3I0Gpk2fd8K9bF4guEBwPFS3r7wCeMZlO
6n9JHsa5dTJuVi7aJphAV90=
=stXI
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040321144528.GF8930>