Date: Wed, 7 May 2014 19:24:03 -0700 From: Warner Losh <imp@bsdimp.com> To: Glen Barber <gjb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r265581 - in head: . share/mk Message-ID: <463883C9-98DE-4C40-A630-FB580432BECE@bsdimp.com> In-Reply-To: <20140508222002.GD1212@hub.FreeBSD.org> References: <201405071815.s47IF3t1010953@svn.freebsd.org> <20140508215720.GB1212@hub.FreeBSD.org> <20140508220435.GC1212@hub.FreeBSD.org> <F5E8C6EB-8CE5-43EC-BB92-ADF4F484486F@bsdimp.com> <20140508222002.GD1212@hub.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On May 8, 2014, at 3:20 PM, Glen Barber <gjb@FreeBSD.org> wrote: > On Wed, May 07, 2014 at 07:09:05PM -0700, Warner Losh wrote: >> >> On May 8, 2014, at 3:04 PM, Glen Barber <gjb@freebsd.org> wrote: >> >>> On Thu, May 08, 2014 at 05:57:20PM -0400, Glen Barber wrote: >>>> On Wed, May 07, 2014 at 06:15:03PM +0000, Warner Losh wrote: >>>>> Author: imp >>>>> Date: Wed May 7 18:15:02 2014 >>>>> New Revision: 265581 >>>>> URL: http://svnweb.freebsd.org/changeset/base/265581 >>>>> >>>>> Log: >>>>> bsd.compiler.mk was implicitly included by bsd.own.mk in historical >>>>> versions. With its movement to src.opts.mk, bsd.prog.mk was testing >>>>> COMPILER_TYPE without including the bsd.compiler.mk anymore. In the >>>>> source tree, this caused no problems, for reasons that aren't clear, >>>>> but does cause problems outside of the source tree. Allow >>>>> bsd.compiler.mk to be included multiple times safely, and always >>>>> include bsd.compiler.mk at the top of bsd.prog.mk. Resist the urge to >>>>> put it in bsd.init.mk, since that would reintroduce the implicit >>>>> include. >>>>> >>>>> Modified: >>>>> head/UPDATING >>>>> head/share/mk/bsd.compiler.mk >>>>> head/share/mk/bsd.prog.mk >>>>> >>>> >>>> Something here is breaking head/ release builds. I don't know if it is >>>> this exact change set or not. >>>> >>>> -------------------------------------------------------------- >>>>>>> Kernel build for GENERIC completed on Thu May 8 01:47:57 UTC 2014 >>>> -------------------------------------------------------------- >>>> make: "/usr/share/mk/bsd.obj.mk" line 43: Could not find bsd.own.mk >>>> make: "/usr/share/mk/bsd.init.mk" line 15: Could not find bsd.own.mk >>>> make: Fatal errors encountered -- cannot continue >>>> make: stopped in /usr/src/release >>>> >>> >>> The revision I'm building against is r265621, for what it is worth. >> >> OK. That’s a weird error. I haven’t deleted bsd.own.mk... >> >> Any chance you can do some bisection to see if there’s a specific >> change you can narrow this down to? But /usr/share/mk suggests >> there’s some host contamination going on, which implies needing to >> have a synchronized host environment (I can’t recall if make release >> is fully virtualized or not). >> >> But before all that, can you confirm you have a /usr/share/mk/bsd.own.mk? >> > > Ugh... This is the problem... > > root@grind:/releng/11-amd64-GENERIC-snap # ll usr/share/mk/bsd.own.mk > ls: usr/share/mk/bsd.own.mk: No such file or directory > > This doesn't make any sense to me though, unless I misunderstand a prior > change here. The host does the buildworld in > /releng/11-amd64-GENERIC-snap/usr/src with MAKEOBJDIRPREFIX set to > a non-default location, and installworld from that. > > In this specific case, the build was done as an "upgrade" build, not > "clean" build (meaning, to seed the build chroot for a clean release > build). I tend to alternate if MAKEOBJDIR is pristine every other week > to try to capture cases where we expect "just 'rm -rf /usr/obj'" as > a "fix" for problems. That’s really odd… Doh, one too many s/bsd.own.mk/src.opts.mk/g is the cause. fix coming. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTaurEAAoJEGwc0Sh9sBEAlosP/3hq42qYhja8z8FArT5m6sKX HfGSdGa3HcEd9lrzH8/30zXdoNIWoONxVhpa9Tiz6qV/zOhUZ9ih+uJxTC0L5o+z H1UdhiFk904JE3sxxltx0owlhfSo0HzNR9bvNzyqJpsdZvG7moWLX3r/6DsrVzKY JdwHX/bGTkqP1pQ6Gfk9O7m9o3BGhR81LETAufEGDFA0EBVXIuNfW6bkV7EtXyky 4BeCN6SzgyHivQLreiZP4s8ll/lajkb50R4R65l/Kfg81EDMeDWfF6sqUhP2BiI3 fmNeMzC9/OVu2PBbKzcbfrTj4aK2DJh+Xs2yTpgf1F1H4hn2jrQ5NEOmlQh4VS4S MXy02Hs0Cf49EwNUN2CKxCn5plhRlW/avnNA8PB4H8hlOD1onZHPoJaBiLDF1ULe pQSz192TgUM/kX45ybusciB+/kBenDzS9xXtmtJ5oFxFq+9XUwISukZ/xfFQiDlg tnIZYF8Vm83jp4f71RV4Acgi+xHMyL6d5o2JO2pCt/C3wTMaWcqowQSpjdDnNB6m XSYTizXNniW44ORF4xerMr3oANhtsmgE5anPH/T5i+mu2lzOjicrWMjPMzlaxYt3 m1vFtIsYcmXQ+a/VHcAulguuqu9I/k5GD+UY1Tblz+ex0+fv/lQheb4RNliap/ib P3y7o1KmPipBl7/ciRxU =qPK8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?463883C9-98DE-4C40-A630-FB580432BECE>