Date: Mon, 15 Feb 2021 16:11:22 -0600 From: Jason Bacon <bacon4000@gmail.com> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: "Jason W. Bacon" <jwb@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r565224 - in head/lang/pocl: . files Message-ID: <604f421a-4b9e-2fd7-bb90-1e0cc0ac9b03@gmail.com> In-Reply-To: <YCmLDdWH9I/fuzp9@elch.exwg.net> References: <202102141304.11ED4BTl046406@repo.freebsd.org> <YCkoTsUm1QeWBzO8@elch.exwg.net> <bbaa5a6a-cde9-052a-e631-7acfcf9b6937@gmail.com> <YCmLDdWH9I/fuzp9@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/14/21 2:41 PM, Christoph Moench-Tegeder wrote:
> ## Jason Bacon (bacon4000@gmail.com):
>
>>> First, while I'm all in favor of consistent white space, mixing this
>>> with the stated (per commit message) change makes the diff harder
>>> to read and "svn annotate" (and similar tools) harder to use later on=
=2E
>> Are you suggesting that whitespace changes should be done in a separat=
e
>> commit?
> Perhaps I wouldn't put it that strongly. More like "think about how tha=
t
> looks like in the commit history".
> This is not a policy, but some options:
> - if you're changing a line anyways, fix the whitespace there at the
> same time
> - lines which will never or rarely change (PORTNAME, MAINTAINER, ...)
> could be whitespace-fixed in their own commit
> - fix the whitespace across the whole file first, then do whatever "rea=
l"
> change you want to do
> - depending on how much you change anyways, it might even not matter
> that much if you "just fix the whitespace on the side".
>
> The guiding principle should be to retain the usefulness of the
> commit diffs and the history: searching that one "real" change in
> dozens of lines of whitespace-only diff can be frustrating, and
> running "{svn,git} annotate" just to end up at that one "fix whitespace=
"
> commit also does not help.
>
> Regards,
> Christoph
>
Sounds reasonable, thanks for the detailed clarification.
Best,
=C2=A0=C2=A0=C2=A0 JB
--=20
Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?604f421a-4b9e-2fd7-bb90-1e0cc0ac9b03>