Date: Fri, 8 Aug 2008 13:43:56 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/io iodev.c Message-ID: <200808081343.m78DhwYE068477@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2008-08-08 13:43:56 UTC
FreeBSD src repository
Modified files:
sys/dev/io iodev.c
Log:
SVN rev 181428 on 2008-08-08 13:43:56Z by ed
Remove D_NEEDGIANT from io(4).
There is no need to mark this device node to use Giant. The only
architectures that use io(4) (i386 and amd64) only change a flag in
td->td_frame, which is only accessed by curthread.
Apart from this change, I think some fishy things may happen when using
/dev/io in multithreaded applications. I haven't tested, but looking at
the code, the flag doesn't get cleared when close() is called from
another thread, but this may not be this important.
I'm not removing D_NEEDGIANT from mem(4), because this driver isn't
Giant safe at all (it calls GIANT_REQUIRED).
Revision Changes Path
1.4 +0 -1 src/sys/dev/io/iodev.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808081343.m78DhwYE068477>