Date: Tue, 5 Oct 2021 18:49:20 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fb5f03a87cf4 - main - Mk/bsd.lto.mk: add global LTO support for ports Message-ID: <YVyCEPlZJvdce4Ak@KGPE-D16> In-Reply-To: <20211005163152.gv2vwvg4nuqwga7q@aching.in.mat.cc> References: <202109301834.18UIYKrL013410@gitrepo.freebsd.org> <20211004133056.z7e2iyrhlwprvvvp@aching.in.mat.cc> <YVx84wGVlSr2nmBX@KGPE-D16> <20211005163152.gv2vwvg4nuqwga7q@aching.in.mat.cc>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 21-10-05 18:31:52, Mathieu Arnold wrote: > On Tue, Oct 05, 2021 at 06:27:15PM +0200, Piotr Kubaj wrote: > > On 21-10-04 15:30:56, Mathieu Arnold wrote: > > > On Thu, Sep 30, 2021 at 06:34:20PM +0000, Piotr Kubaj wrote: > > > > The branch main has been updated by pkubaj: > > > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=fb5f03a87cf432751fae1f0ae7f29c9d4fc65917 > > > > > > > > commit fb5f03a87cf432751fae1f0ae7f29c9d4fc65917 > > > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > > > AuthorDate: 2021-09-30 18:27:50 +0000 > > > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > > > CommitDate: 2021-09-30 18:27:50 +0000 > > > > > > > > Mk/bsd.lto.mk: add global LTO support for ports > > > > > > > > It's well known that LTO provides both performance and size benefits for > > > > binaries. > > > > > > > > Add preliminary, opt-in support for global LTO enforcement to ports. Ports that > > > > provide LTO option on their own and the ones that don't work with LTO will need > > > > to set LTO_UNSAFE in the future. > > > > > > > > PR: 258536 > > > > > > Not to be picky about approval and all, but this was added to the > > > framework, and the framework is maintained by portmgr. When you want to > > > add something to it, you must consult with portmgr before anything gets > > > committed. > > > > > > In that case, we would have told you not to do it this way, but to make > > > this a Mk/Uses/lto.mk. > > > > > > So please, turn this into a USES=lto. > > > > I did consult, but no one replied. > > There is absolutely no maintainer timeout for the framework, you cannot > just add code there without explicit approval. And this is a port of a bigger issue, where portmgr ignores emails until numerously asked for (if one is lucky). As one of users wrote in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251117, for which portmgr is assigned, "portmgr@ more and more feels to me like a black hole, or /dev/null: Anything sent there seems to disappear without effect." Since it was a change that doesn't change anything out-of-the-box, I decided to commit it. > > > IMO adding it to USES is not a good idea, since USES are supposed to be used per port and my idea was to force LTO for all ports, same way that SSP already does. > > All I see in the patch is a USE_LTO knob, and a LTO_UNSAFE one, without > any documentation of what it is for, what it does, what it might do, > what it is about, or anything else. Neither has SSP, I don't see any documentation for it (including commiter handbook which has just one line regarding USES=kmod at https://docs.freebsd.org/en/books/porters-handbook/book/#uses-kmod). > > -- > Mathieu Arnold [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFcghAACgkQelmbhSCD nJ0wpQ//fYKMm0WBk1bpSrPhLY0IruNs1oHFpUQrhJj2rzak/ko0oFBVxRTTJc7E Y3kbLYdDlFzR7uH3Aiz8O2TuqtcoSc8A4eOfdVmo37D9QJLcifu7jtg9RzlslhMT AZrAzCwavk78IK8nG/BeqOtAgcC5dzGPEOx79RSKRIA0G2qieyqDIOiVgv6nS8b9 g+t7gSzfQSEeADtIpjneIhdG+/uRLr7JPir4JqVXQekBi3V5bBWcjhRof3DmaqHT EG1ie8nVbZMKIdj8JzgpLtCPFud2AWpW6hAdubCWFlJL6+dkstmGrUM+fyKh5tCn b5o4uyCRYNtgRiys+cSvJFILdiUAVSlnNm4tiiP1aRihkBAsk8GSYM7KkyfPx63b NvUr6UGFqFE7OSbxFPx9RnhzT45Yxye7vB01k0Q29Qav9Y2ga/PvnoWn1AKIIV/2 YsbBFKJ5G4Q9Xkt7QlfUoqVdrtNDcUtHj/DbaDYssULFj6a7hyEDqqLRtamVMewe BJk+Yap+gaxcizb+zHWnBm0nZoqNfi95/NNkhRARi8NhIPgIxUQJNzn2C/KDoQDk yqf2mgUTgQjAK5JKOtxg7XAg0X06/4Kj6zmkeFoXntbdQpSH32ACItp6vof7GPJc cDXXAIpz+6CSs+BQZXyIvQqu7PFuC3DTTOc596TH5HycmXFBR4Q= =7irM -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVyCEPlZJvdce4Ak>