Date: Tue, 01 Sep 2020 21:08:58 +0000 From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 248955] [PATCH] net80211: fix ieee80211_media_change() return value Message-ID: <bug-248955-21060-hvnfIbx9QV@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-248955-21060@https.bugs.freebsd.org/bugzilla/> References: <bug-248955-21060@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248955 Bjoern A. Zeeb <bz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open Assignee|bz@FreeBSD.org |wireless@FreeBSD.org --- Comment #1 from Bjoern A. Zeeb <bz@FreeBSD.org> --- I am not sure this is the correct fix. A lot of drivers also pass it to ieee80211_vap_attach() which then tickles down to ifmedia_init() where it is set to ifm->ifm_change = change_callback; ifmedia_ioctl() then checks for a != 0 error. Seems to be a good copy&paste error either way as one or the other case will break. It seems in r178354 the first factoring out of things happened, when it could still return ENETRESET which was then after successive changes removed in https://svnweb.freebsd.org/base/head/sys/net80211/ieee80211.c?r1=193339&r2=193340&; which is the code as it is today. As a conclusion I'd say the drivers have not been updated to reflect these changes after r178354; see https://svnweb.freebsd.org/base/head/sys/dev/ath/if_ath.c?r1=178353&r2=178354&; for why this still was. Would you follow the conclusion that these days the drivers could savely check for != 0 and we should rather fix (the ones I found): ./dev/ath/if_ath.c ./dev/bwi/if_bwi.c ./dev/iwm/if_iwm.c ./dev/iwn/if_iwn.c ./dev/malo/if_malo.c ./dev/mwl/if_mwl.c ./dev/otus/if_otus.c ./dev/usb/wlan/if_run.c ./dev/wtap/if_wtap.c Cc:ing re-assigning back to the list so that other driver maintainers will also see. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248955-21060-hvnfIbx9QV>