Date: Tue, 3 May 2022 22:08:29 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Jan Beich <jbeich@FreeBSD.org> Cc: Christoph Moench-Tegeder <cmt@burggraben.net>, Joseph Mingrone <jrm@freebsd.org>, Craig Leres <leres@freebsd.org>, Christoph Moench-Tegeder <cmt@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 980444a82fbd - main - www/firefox: update to 100.0 (rc2) Message-ID: <20220503220829.e6077c4e739125a64e20b1ea@bidouilliste.com> In-Reply-To: <a6by-blrw-wny@FreeBSD.org> References: <202204291458.23TEwiL4068411@gitrepo.freebsd.org> <58e45f7c-b79f-9f14-4df5-00617fee9ea4@freebsd.org> <YnAm4GoVYvfpyr9E@elch.exwg.net> <05c2a241-5d32-24d9-c223-66aa9ca99b75@freebsd.org> <YnBU8c5L6eNIn5mB@elch.exwg.net> <76d4fb65-b1df-2941-cc06-5ab23607a233@freebsd.org> <d9e5419b-3d4e-ab4b-5fbe-8306cc7196cd@freebsd.org> <20220503094616.ad8309626972ab0c7d6c1cd9@bidouilliste.com> <4k26-hkiv-wny@FreeBSD.org> <86y1ziab1f.fsf@phe.ftfl.ca> <YnFOCpAQ5pvts3e4@elch.exwg.net> <20220503175240.89a47079840b06ce1a6cc22a@bidouilliste.com> <a6by-blrw-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 03 May 2022 18:53:23 +0200 Jan Beich <jbeich@FreeBSD.org> wrote: > Emmanuel Vadot <manu@bidouilliste.com> writes: > > > On Tue, 3 May 2022 17:45:14 +0200 > > Christoph Moench-Tegeder <cmt@burggraben.net> wrote: > > > >> ## Joseph Mingrone (jrm@FreeBSD.org): > >> > >> > Turning LTO off fixed the problem here. > >> > >> I just found out that turning LTO on breaks firefox for me, so that > >> settles that. I'll push that soon. > > > > That's good for now thanks but what about the futur ? > > Should we allow to have LTO turn on on port that uses both LLVM and > > Rust ? Because otherwise it will happen again when a new rust version > > if released and the llvm version isn't the same. > > - Known since https://cgit.freebsd.org/ports/commit/?id=b1c90afe23f9 > - Adhered previously in https://cgit.freebsd.org/ports/commit/?id=124261fa7deb > - Complicated by wasi-compiler-rt* split from llvm* packages > > Mozilla recommends its own Firefox builds due to LTO + PGO. FreeBSD is a > Tier3 (aka "patches welcome" and no CI), so disabling LTO will reduce > performance with no fallback binaries. Rebuilding Firefox locally isn't > a good proposition due to long build time (more with LTO), high memory > requirement (more with LTO), frequent updates to firefox and many of its > dependencies (harfbuzz, nss, ffmpeg, etc). > > I've enabled LTO by default a year ago to prevent dilapidation. Back then > when LTO was exposed there were numerious bug reports about broken build. I'm glad that it's known for a year and that no one tried to make a policy that will prevent this from even happening. What's the perf impact on disabling LTO on Firefox ? -- Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220503220829.e6077c4e739125a64e20b1ea>