Date: Thu, 5 Feb 2026 05:12:26 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Abdelkader Boudih <freebsd@seuros.com>, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 052a791b0055 - main - acpi: add Darwin OSI quirk for Apple Mac hardware Message-ID: <aYQKmiCpxW_sEU4Y@kib.kiev.ua> In-Reply-To: <25B2F11A-19F2-452E-971E-3C2C953540C5@gmail.com> References: <698154c0.35e9d.2d7b8775@gitrepo.freebsd.org> <aYGIvC3v0zQCJrGo@kib.kiev.ua> <0A69735E-8BF6-41B1-AB7A-9B761A0FF158@gmail.com> <aYGqHESSZPxYL9QZ@kib.kiev.ua> <63ee9a06-97bd-4f7f-8bb8-ed39382d94a4@app.fastmail.com> <aYHQQO61CR_DxCbQ@kib.kiev.ua> <F0F80955-2AA1-464A-914B-8B602D4D79A9@gmail.com> <aYO3fobNQFFsYuAo@kib.kiev.ua> <25B2F11A-19F2-452E-971E-3C2C953540C5@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Wed, Feb 04, 2026 at 07:02:00PM -0800, Enji Cooper (yaneurabeya) wrote: > > > On Feb 4, 2026, at 1:17 PM, Konstantin Belousov <kostikbel@gmail.com> wrote: > > > > On Tue, Feb 03, 2026 at 10:25:27PM -0800, Enji Cooper (yaneurabeya) wrote: > >> > >>> On Feb 3, 2026, at 2:38 AM, Konstantin Belousov <kostikbel@gmail.com> wrote: > >>> > >>> On Tue, Feb 03, 2026 at 11:08:40AM +0100, Abdelkader Boudih wrote: > >>>> I agree that this should not be permanent verbosity. > >>>> > >>>> The aim was not to add long-term noise, but to make the behavior observable/greppable to reviewers while this logic is still being validated across a wide range of Apple models. > >>>> > >>>> I'm going to get few Apple devices to try on. Once we confirm that every model behave the same, we could totally remove verbosity and treating it as assumed-working code. > >> > >> One sidenote: this is hidden behind bootverbose: it’s not always being displayed. > >> > >> I think it’s fine making the message more terse. It might clarify behavior on Apple platforms since the added behavior contradicts other OSI-related behavior and can result in a POLA violation. > > > > Can you fix it, please, instead thinking that it might be fine? > > Done: https://cgit.freebsd.org/src/commit/?id=9c666de5b339d3c8f9bf3963691e4310e7d159cb > -Enji Thank you.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aYQKmiCpxW_sEU4Y>