Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Jul 2013 10:31:16 GMT
From:      Jonathan Anderson <jonathan@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 231278 for review
Message-ID:  <201307191031.r6JAVGHt029747@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@231278?ac=10

Change 231278 by jonathan@jonathan-on-zenith on 2013/07/19 10:30:17

	Pull in DTrace improvements from GitHub.

Affected files ...

.. //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/include/libtesla.h#11 edit
.. //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/libtesla/tesla_dtrace.c#8 edit

Differences ...

==== //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/include/libtesla.h#11 (text+ko) ====

@@ -168,6 +168,9 @@
 
 	/** Possible transitions: exactly one must be taken. */
 	struct tesla_transition	*transitions;
+
+	/** A human-readable description for debugging purposes. */
+	const char		*description;
 };
 
 #define	TESLA_KEY_SIZE		4

==== //depot/projects/ctsrd/tesla/src/sys/contrib/tesla/libtesla/tesla_dtrace.c#8 (text+ko) ====

@@ -47,7 +47,7 @@
     "struct tesla_class *", "struct tesla_instance *",
     "struct tesla_instance *", "struct tesla_transition *");
 SDT_PROBE_DEFINE3(tesla, automata, fail, no_instance, no-instance-match,
-    "struct tesla_class *", "struct tesla_key *",
+    "struct tesla_class *", "const char *",
     "struct tesla_transitions *");
 SDT_PROBE_DEFINE3(tesla, automata, fail, bad_transition, bad-transition,
     "struct tesla_class *", "struct tesla_instance *",
@@ -87,8 +87,10 @@
 no_instance(struct tesla_class *tcp, const struct tesla_key *tkp,
     const struct tesla_transitions *ttp)
 {
+	char keybuf[20];
+	key_string(keybuf, keybuf + sizeof(keybuf), tkp);
 
-	SDT_PROBE(tesla, automata, fail, no_instance, tcp, tkp, ttp, 0, 0);
+	SDT_PROBE(tesla, automata, fail, no_instance, tcp, keybuf, ttp, 0, 0);
 }
 
 static void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307191031.r6JAVGHt029747>