Date: Thu, 17 May 2018 21:27:57 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: Matthew Macy <mmacy@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333745 - in head/sys/contrib/ck: include src Message-ID: <20180517212757.84c7b02060ca8f86e56dbee9@bidouilliste.com> In-Reply-To: <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org> References: <201805171814.w4HIEA0F079835@repo.freebsd.org> <20180517203856.aa6b8b241e23b9c07483232b@bidouilliste.com> <CAPrugNoX0n3TV90r0AARGSo16=gt2xOidsD17nxBHV1W_jbiuw@mail.gmail.com> <17058056-6b70-e918-dab8-63951d1bfbbd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 17 May 2018 14:20:05 -0500 Pedro Giffuni <pfg@FreeBSD.org> wrote: > > On 17/05/2018 14:12, Matthew Macy wrote: > > How do I avoid problems while allowing timely updates? > > > > -M > > > > On Thu, May 17, 2018 at 11:38 AM, Emmanuel Vadot <manu@bidouilliste.com> wrote: > >> Hi Matt, > >> > >> On Thu, 17 May 2018 18:14:10 +0000 (UTC) > >> Matt Macy <mmacy@FreeBSD.org> wrote: > >> > >>> Author: mmacy > >>> Date: Thu May 17 18:14:10 2018 > >>> New Revision: 333745 > >>> URL: https://svnweb.freebsd.org/changeset/base/333745 > >>> > >>> Log: > >>> ck: add support for executing callbacks outside of main poll loop > >>> > >>> Pull in change from upstream deca119d14bfffd440770eb67cbdbeaf7b57eb7b > >>> > >>> | ck_epoch: introduce ck_epoch_deferred > >>> | > >>> | Allow for deferral to occur outside epoch poll critical loop (which may access per-CPU structures). > >>> | > >>> > >>> Approved by: sbruno > >>> > >>> Modified: > >>> head/sys/contrib/ck/include/ck_epoch.h > >>> head/sys/contrib/ck/src/ck_epoch.c > >>> > >> CK was imported in vendor-sys/ck, commiting directly into head will > >> cause some problems in the future. > > Actually ... committing to head is fine: some things just have to be fixed. This is not true, it can cause a lot of problems with futures updates if the change isn't in the vendor repo. > We do ask you try to upstream the change and re-merge things when possible. This is already upstream, Matt is just updating CK with a patch he did ( see https://github.com/concurrencykit/ck/commit/deca119d14bfffd440770eb67cbdbeaf7b57eb7b) > Pedro. -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180517212757.84c7b02060ca8f86e56dbee9>