Date: Sat, 3 Dec 2022 12:20:33 +0100 (CET) From: freebsd@oldach.net (Helge Oldach) To: allanjude@FreeBSD.org (Allan Jude) Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: c6ec1b441ad3 - stable/13 - Add support for adding default routes for other FIBs Message-ID: <202212031120.2B3BKXP3040101@nuc.oldach.net> In-Reply-To: <202212022128.2B2LSLw9019473@gitrepo.freebsd.org> from Allan Jude at "2 Dec 2022 21:28:21"
next in thread | previous in thread | raw e-mail | index | archive | help
Hi all, Allan Jude wrote on Fri, 02 Dec 2022 22:28:21 +0100 (CET): > The branch stable/13 has been updated by allanjude: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c6ec1b441ad3fdfa2d3a22d0b66d53006c5e292b > > commit c6ec1b441ad3fdfa2d3a22d0b66d53006c5e292b > Author: Andrew Fengler <andrew.fengler@scaleengine.com> > AuthorDate: 2021-05-12 01:59:10 +0000 > Commit: Allan Jude <allanjude@FreeBSD.org> > CommitDate: 2022-12-02 21:27:57 +0000 > > Add support for adding default routes for other FIBs I suspect there is a small glitch which effectively defeats the functionality: > + ;; > + *) > + static_routes="${static_routes} _default_fib${_fibnum}" > + eval route__default_fib${fibnum}="'default ${_fib_gw} -fib ${_fibnum}'" This "${fibnum}" should read "${_fibnum}" (with an underscore), as there is no ${fibnum} variable at all. > + ;; > + *) > + ipv6_static_routes="${static_routes} _default_fib${_fibnum}" > + eval ipv6_route__default_fib${fibnum}="'default ${_fib_gw} -fib ${_fibnum}'" Same here for the IPv6 case. It should probably be fixed in HEAD as well. Kind regards Helge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202212031120.2B3BKXP3040101>