Date: Mon, 31 Mar 2014 13:25:35 +0900 From: Yonghyeon PYUN <pyunyh@gmail.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: svn commit: r263957 - in head/sys: dev/age dev/alc dev/ale dev/bce dev/bge dev/fxp dev/jme dev/msk dev/nfe dev/sge pci Message-ID: <20140331042535.GA1359@michelle.cdnetworks.com> In-Reply-To: <20140331040058.GV60889@funkthat.com> References: <201403310154.s2V1sxXY010836@svn.freebsd.org> <20140331040058.GV60889@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 30, 2014 at 09:00:59PM -0700, John-Mark Gurney wrote: > Pyun YongHyeon wrote this message on Mon, Mar 31, 2014 at 01:54 +0000: > > Author: yongari > > Date: Mon Mar 31 01:54:59 2014 > > New Revision: 263957 > > URL: http://svnweb.freebsd.org/changeset/base/263957 > > > > Log: > > Increase the number of TX DMA segments from 32 to 35. It turned > > out 32 is not enough to support a full sized TSO packet. > > While I'm here fix a long standing bug introduced in r169632 in > > bce(4) where it didn't include L2 header length of TSO packet in > > the maximum DMA segment size calculation. > > I assume all of the hardware supports this increase? > Yes. Data sheet does not mention about such limitation. txp(4) has a limitation on the number of TX segments but I didn't implement TSO in txp(4). > Also, is there a reason to only increase up to 35 and not something > larger, like 64? Is there a memory or performance penalty? > If 64 does not overflow kernel stack we can also bump the number to 64.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140331042535.GA1359>