Date: Mon, 27 Oct 2003 16:15:02 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: "Kenneth D. Merry" <ken@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam cam_periph.c src/sys/cam/scsi scsi_cd.c Message-ID: <ybs7k2r2lu1.wl@ett.sat.t.u-tokyo.ac.jp> In-Reply-To: <200310270615.h9R6FtQY038957@repoman.freebsd.org> References: <200310270615.h9R6FtQY038957@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I have a similar problem with a da device too. It's a FireWire/compat flash adaptor(a removable da device). Though I forgot the detail, it takes too long time to probe if the media is not present. Do we have to patch scsi_da.c too? /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html At Sun, 26 Oct 2003 22:15:55 -0800 (PST), Kenneth D. Merry wrote: > > ken 2003/10/26 22:15:55 PST > > FreeBSD src repository > > Modified files: > sys/cam cam_periph.c > sys/cam/scsi scsi_cd.c > Log: > In camperiphdone(), make sure we check for fatal errors and bail out > instead of retrying them blindly. > > This should fix some of the problems people have been having with cdrom > drives taking a long time to probe. This should also eliminate the need > for the initial TUR in cdsize(). > > cam_periph.c: Don't keep retrying if the error we get back is a fatal > error. This should help us detect the transition from > "Logical unit not ready, cause not reportable" to "Medium > not present" in the "TUR many" handler. (The TUR many > handler gets triggered for Logical unit not ready, cause > not reportable errors.) > > scsi_cd.c: Remove the initial test unit ready in cdsize(). Hopefully > it isn't necessary after the above change. > > Submitted by: gibbs (mostly) > Tested by: peter > MFC After: 2 weeks > > Revision Changes Path > 1.55 +17 -2 src/sys/cam/cam_periph.c > 1.88 +0 -14 src/sys/cam/scsi/scsi_cd.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ybs7k2r2lu1.wl>