Date: Thu, 22 Jul 2010 16:43:14 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Dimitry Andric <dimitry@andric.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: svn commit: r210384 - head/sys/conf Message-ID: <201007221643.20257.jkim@FreeBSD.org> In-Reply-To: <4C48AB65.1030207@andric.com> References: <201007221847.o6MIlfxH030805@svn.freebsd.org> <201007221614.11334.jkim@FreeBSD.org> <4C48AB65.1030207@andric.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 22 July 2010 04:34 pm, Dimitry Andric wrote:
> On 2010-07-22 22:13, Jung-uk Kim wrote:
> >> CFLAGS= ${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS}
> >> CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> >> -include opt_global.h -.if ${CC} != "icc"
> >> +.if ${CC} != "icc" && ${CC} != "clang"
> >> CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT}
> >> .if ${MACHINE_CPUARCH} != "mips"
> >> CFLAGS+= --param inline-unit-growth=100
> >
> > Isn't it little premature to remove -Werror from clang?
>
> Yes, probably. Please consider the attached patch, which only rubs
> out the compilation options that clang does not support.
Looks good to me. Please commit.
Thanks!
Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007221643.20257.jkim>