Date: Wed, 29 Jan 2014 11:53:23 +0100 From: Hans Petter Selasky <hps@bitfrost.no> To: "Lundberg, Johannes" <johannes@brilliantservice.co.jp>, Adrian Chadd <adrian@freebsd.org> Cc: =?UTF-8?B?6buE5paH6L6J?= <huanghwh@gmail.com>, freebsd-current <freebsd-current@freebsd.org>, "freebsd-usb@freebsd.org" <freebsd-usb@freebsd.org>, "kwm@freebsd.org" <kwm@freebsd.org> Subject: Re: Apple Trackpad driver Message-ID: <52E8DDA3.3070301@bitfrost.no> In-Reply-To: <CAASDrVmqijq51OEH7USLutPSgme7YWhXZZX4tGROLHVPoz2VkA@mail.gmail.com> References: <CAB8uncaLEn4CaJv8%2BowESe_zUUK%2Bgem_bXpEjhsOJE69m_fWAg@mail.gmail.com> <CAJ-Vmon4Gk6bqoT%2BJf-bRxE0%2BNJ1NjR0wjum-HjoVFDN-2e=8Q@mail.gmail.com> <CAASDrV=pbDpZCGvEjnD8VS0D_HyC8=L3jQ7rfGszG6=PtxaE3Q@mail.gmail.com> <CAASDrVmqijq51OEH7USLutPSgme7YWhXZZX4tGROLHVPoz2VkA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------050509010807080800010305 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/29/14 09:49, Lundberg, Johannes wrote: > Hi > > I tested the driver on a 2012 Macbook Air 11" and it works great! Good job! > > Is there a way to disable click-by-touch? I always preferred clicking with > the physical button that is built in to the pad. > Hi, I've added an "#if 0" around the 1 finger tap code until further. Maybe this feature can be tunable? I fixed the code style, added some range checks and cleared some buffer issues. When you assign a signed value to an unsigned variable, you should range check it, because the sign might cause an overflow when you use it later on. int8_t x = -1; uint32_t t = x; "t" is now "0xffffffffU" and not "255". Tested the code on my MacBookPro. Hope I didn't break anything. If so, send a patch to freebsd-usb. http://svnweb.freebsd.org/changeset/base/261260 To get the touchpad working with Xorg, I needed to re-compile HALD with the attached patch. kwm: Can you get the attached patch into ports? Auto-loading of wsp via devd will be done later. Simply need to re-generate usb.conf in /etc ... --HPS --------------050509010807080800010305 Content-Type: text/x-diff; name="patch-hald_freebsd_hf-usb2.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patch-hald_freebsd_hf-usb2.c.diff" --- patch-hald_freebsd_hf-usb2.c.orig 2014-01-29 11:50:11.000000000 +0100 +++ patch-hald_freebsd_hf-usb2.c 2014-01-29 11:50:36.000000000 +0100 @@ -61,7 +61,7 @@ + if (driver) { + if (!strcmp(driver, "ukbd")) + hf_device_set_input(device, "keyboard", "keys", NULL); -+ else if (!strcmp(driver, "ums") || !strcmp(driver, "atp")) { ++ else if (!strcmp(driver, "ums") || !strcmp(driver, "atp") || !strcmp(driver, "wsp")) { + hf_device_set_input(device, "mouse", NULL, devname); + hf_runner_run_sync(device, 0, "hald-probe-mouse", NULL); + } else if (!strcmp(driver, "uhid")) { --------------050509010807080800010305--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52E8DDA3.3070301>