Date: Fri, 24 Apr 2015 11:17:47 -0400 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: John Baldwin <jhb@freebsd.org>, Sergey Kandaurov <pluknet@freebsd.org> Cc: Edward Tomasz Napierala <trasz@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281922 - head/usr.bin/nfsstat Message-ID: <553A5E9B.7090503@FreeBSD.org> In-Reply-To: <1589639.roM6gzoYx3@ralph.baldwin.cx> References: <201504240758.t3O7w0o1022549@svn.freebsd.org> <CAE-mSOLnh_m48rgDPmVf0LmJYvy9KGfXjai-jCfh4LJnx8U-gg@mail.gmail.com> <1589639.roM6gzoYx3@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/24/2015 10:33, John Baldwin wrote: > On Friday, April 24, 2015 02:31:31 PM Sergey Kandaurov wrote: >> On 24 April 2015 at 10:58, Edward Tomasz Napierala <trasz@freebsd.org> wrote: >>> Author: trasz >>> Date: Fri Apr 24 07:57:59 2015 >>> New Revision: 281922 >>> URL: https://svnweb.freebsd.org/changeset/base/281922 >>> >>> Log: >>> Make nfsstat(1) build with WARNS=6. >>> >>> Sponsored by: The FreeBSD Foundation >>> >>> Modified: >>> head/usr.bin/nfsstat/Makefile >>> head/usr.bin/nfsstat/nfsstat.c >>> >>> Modified: head/usr.bin/nfsstat/Makefile >>> ============================================================================== >>> --- head/usr.bin/nfsstat/Makefile Fri Apr 24 07:52:21 2015 (r281921) >>> +++ head/usr.bin/nfsstat/Makefile Fri Apr 24 07:57:59 2015 (r281922) >>> @@ -6,6 +6,4 @@ CFLAGS+=-DNFS >>> >>> LIBADD= kvm >>> >>> -WARNS?= 3 >>> - >>> .include <bsd.prog.mk> >>> >>> Modified: head/usr.bin/nfsstat/nfsstat.c >>> ============================================================================== >>> --- head/usr.bin/nfsstat/nfsstat.c Fri Apr 24 07:52:21 2015 (r281921) >>> +++ head/usr.bin/nfsstat/nfsstat.c Fri Apr 24 07:57:59 2015 (r281922) >>> @@ -70,15 +70,6 @@ static const char rcsid[] = >>> #include <paths.h> >>> #include <err.h> >>> >>> -struct nlist nl[] = { >>> -#define N_NFSSTAT 0 >>> - { .n_name = "nfsstats" }, >>> -#define N_NFSRVSTAT 1 >>> - { .n_name = "nfsrvstats" }, >>> - { .n_name = NULL }, >>> -}; >>> -kvm_t *kd; >>> - >>> static int widemode = 0; >>> static int zflag = 0; >>> static int printtitle = 1; >>> >> >> Now that nfsstat no longer uses kvm to extract statistics, it could be >> further trimmed. >> - no longer link with kvm >> - un-document -M/-N options but still kept (?) for backward compatibility >> - cleanup from the previous sysctl/kvm usage. > > If these are just global structures in the kernel it would be nice to keep > -N/-M support for use in crash dump reporting. This just broke crashinfo > (again), so please either restore KVM support for crash reporting, or > remove nfsstat from crashinfo. ...or implement debugger scripts that provide similar functionality, and call those from crashinfo. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?553A5E9B.7090503>