Date: Fri, 22 May 2009 10:32:43 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: =?utf-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no> Cc: svn-src-head@FreeBSD.org, Rick Macklem <rmacklem@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r192463 - head/sys/fs/nfsserver Message-ID: <Pine.GSO.4.63.0905221024420.105@muncher.cs.uoguelph.ca> In-Reply-To: <86r5yhzaso.fsf@ds4.des.no> References: <200905201858.n4KIw7Fc040619@svn.freebsd.org> <86r5yhzaso.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---559023410-851401618-1243002763=:105 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Fri, 22 May 2009, Dag-Erling Sm=C3=B8rgrav wrote: > Rick Macklem <rmacklem@FreeBSD.org> writes: >> Log: >> Although it should never happen, all the nfsv4 server can do >> when it runs out of clientids is reboot. I had replaced cpu_reboot() >> with printf(), since cpu_reboot() doesn't exist for sparc64. >> This change replaces the printf() with panic(), so the reboot >> would occur for this highly unlikely occurrence. > > Regardless of how improbable this is, wouldn't it be better (and > simpler) to just log an error message and deny further mount requests? > Well, it this really is an issue I can just take the check for the wraparound out and let it continue on. Why? Because the likelyhood of a clientid issued 4billion time ago (many many years aka centuries, in practice) being for a client that still exists and hasn't rebooted or re-acquired a more recent clientid is essentialy 0 as well. In case you haven't done the calculation, 4billion seconds is 136 years. Since I cannot image a server seeing anything close to 1 new clientid/sec over an extended period (there could be a burst just after booting), the wraparound will take centuries to happen (maybe highly unlikely wasn't a strong enough term). Just don't worry about it, rick ---559023410-851401618-1243002763=:105--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.63.0905221024420.105>