Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Aug 2020 00:28:28 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r364789 - in stable/12/sys: amd64/acpica arm64/acpica i386/acpica
Message-ID:  <202008260028.07Q0SSb1065949@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Wed Aug 26 00:28:28 2020
New Revision: 364789
URL: https://svnweb.freebsd.org/changeset/base/364789

Log:
  MFC r364399: Remove some noisy ACPI tables messages from verbose dmesg.
  
  Those messages were printed hundreds of times during boot, often multiple
  times for each table.  We already print information about the tables in
  more organized form once to not duplicate it when random ACPI drivers are
  attaching.

Modified:
  stable/12/sys/amd64/acpica/acpi_machdep.c
  stable/12/sys/arm64/acpica/acpi_machdep.c
  stable/12/sys/i386/acpica/acpi_machdep.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/amd64/acpica/acpi_machdep.c
==============================================================================
--- stable/12/sys/amd64/acpica/acpi_machdep.c	Tue Aug 25 23:35:55 2020	(r364788)
+++ stable/12/sys/amd64/acpica/acpi_machdep.c	Wed Aug 26 00:28:28 2020	(r364789)
@@ -132,9 +132,6 @@ probe_table(vm_paddr_t address, const char *sig)
 
 	table = pmap_mapbios(address, sizeof(ACPI_TABLE_HEADER));
 	ret = strncmp(table->Signature, sig, ACPI_NAMESEG_SIZE) == 0;
-	if (bootverbose)
-		printf("Table '%.4s' at 0x%jx\n", table->Signature,
-		    (uintmax_t)address);
 	pmap_unmapbios((vm_offset_t)table, sizeof(ACPI_TABLE_HEADER));
 	return (ret);
 }
@@ -239,13 +236,8 @@ acpi_find_table(const char *sig)
 		acpi_unmap_table(rsdt);
 	}
 	pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP));
-	if (addr == 0) {
-		if (bootverbose)
-			printf("ACPI: No %s table found\n", sig);
+	if (addr == 0)
 		return (0);
-	}
-	if (bootverbose)
-		printf("%s: Found table at 0x%jx\n", sig, (uintmax_t)addr);
 
 	/*
 	 * Verify that we can map the full table and that its checksum is

Modified: stable/12/sys/arm64/acpica/acpi_machdep.c
==============================================================================
--- stable/12/sys/arm64/acpica/acpi_machdep.c	Tue Aug 25 23:35:55 2020	(r364788)
+++ stable/12/sys/arm64/acpica/acpi_machdep.c	Wed Aug 26 00:28:28 2020	(r364789)
@@ -103,9 +103,6 @@ probe_table(vm_paddr_t address, const char *sig)
 			    (uintmax_t)address);
 		return (0);
 	}
-	if (bootverbose)
-		printf("Table '%.4s' at 0x%jx\n", table->Signature,
-		    (uintmax_t)address);
 
 	if (strncmp(table->Signature, sig, ACPI_NAMESEG_SIZE) != 0) {
 		pmap_unmapbios((vm_offset_t)table, sizeof(ACPI_TABLE_HEADER));
@@ -198,13 +195,8 @@ acpi_find_table(const char *sig)
 	}
 	pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP));
 
-	if (addr == 0) {
-		if (bootverbose)
-			printf("ACPI: No %s table found\n", sig);
+	if (addr == 0)
 		return (0);
-	}
-	if (bootverbose)
-		printf("%s: Found table at 0x%jx\n", sig, (uintmax_t)addr);
 
 	/*
 	 * Verify that we can map the full table and that its checksum is

Modified: stable/12/sys/i386/acpica/acpi_machdep.c
==============================================================================
--- stable/12/sys/i386/acpica/acpi_machdep.c	Tue Aug 25 23:35:55 2020	(r364788)
+++ stable/12/sys/i386/acpica/acpi_machdep.c	Wed Aug 26 00:28:28 2020	(r364789)
@@ -149,9 +149,6 @@ probe_table(vm_paddr_t address, const char *sig)
 	int ret;
 
 	table = pmap_mapbios(address, sizeof(ACPI_TABLE_HEADER));
-	if (bootverbose)
-		printf("Table '%.4s' at 0x%jx\n", table->Signature,
-		    (uintmax_t)address);
 	ret = strncmp(table->Signature, sig, ACPI_NAMESEG_SIZE) == 0;
 	pmap_unmapbios((vm_offset_t)table, sizeof(ACPI_TABLE_HEADER));
 	return (ret);
@@ -257,13 +254,8 @@ acpi_find_table(const char *sig)
 		acpi_unmap_table(rsdt);
 	}
 	pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP));
-	if (addr == 0) {
-		if (bootverbose)
-			printf("ACPI: No %s table found\n", sig);
+	if (addr == 0)
 		return (0);
-	}
-	if (bootverbose)
-		printf("%s: Found table at 0x%jx\n", sig, (uintmax_t)addr);
 
 	/*
 	 * Verify that we can map the full table and that its checksum is



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202008260028.07Q0SSb1065949>