Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Apr 2022 17:47:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 263371] Possible memleak bugs caused by g_raid_destroy_volume()
Message-ID:  <bug-263371-227-7Y92i3JZew@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-263371-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-263371-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263371

--- Comment #1 from Yuri <yuri@aetern.org> ---
The advise would be taking static analyzer output with a grain of salt (or a
ton, actually) and asking questions on relevant mailing lists instead of us=
ing
bugtracker when in doubt.

For the report itself, if I understand the code correctly, the
vol->v_provider_open !=3D 0 check above all of the g_raid_destroy_volume() =
calls
makes sure all of the code paths returning EBUSY will not be taken.  It wou=
ld
help though to have (void) casts when we are not interested in return value=
s to
mark it as "intended".

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-263371-227-7Y92i3JZew>