Date: Mon, 24 Aug 2020 13:45:00 +0200 From: Mathieu Arnold <mat@freebsd.org> To: "Lev A. Serebryakov" <lev@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r545609 - in head/devel/gcc-msp430-ti-toolchain: . files Message-ID: <20200824114500.7ve4g5j4sikly5ek@aching.in.mat.cc> In-Reply-To: <202008211551.07LFpPdb047611@repo.freebsd.org> References: <202008211551.07LFpPdb047611@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qw2kmjdrrqrgvxvq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Aug 21, 2020 at 03:51:25PM +0000, Lev A. Serebryakov wrote:
> +# Strip binaries
> +.if !defined(DEBUG)
> + @for bin in $$(${FIND} ${INTERIM_PREFIX}/bin -type f -name ${TARGET}-\*=
) ; do \
> + if ! ${FILE} $$bin | ${GREP} -qs ': ELF' ; then continue ; fi ; \
> + ${STRIP_CMD} $${bin} ; \
> + done
Is there a particular reason for doing things in a way that convoluted?
I mean, is there a reason for not doing it in a straight way like this:
@for bin in $$(${FIND} ${INTERIM_PREFIX}/bin -type f -name ${TARGET}-\*) ;=
do \
if ${FILE} $$bin | ${GREP} -qs ': ELF' ; then \
${STRIP_CMD} $${bin} ; \
fi ; \
done
We usually write `if something I want; then somethig; fi`.
The `if something I don't want; then continue; fi; something` is reather
strange.
--=20
Mathieu Arnold
--qw2kmjdrrqrgvxvq
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl9DqDhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgJsDw/+NlBVxQbWGhdfVDZH0iqKCxweHMBdTtb2KP70Gm5K1kr5uM03Jv6G1ybi
fd6oQFqC2jKkpdAb+iUaBaoE/k7+d6qGg6jiUl8PtZd4nd+Zjwit9/kOcZeXQ+es
URJyUaEb633SPFsGjLiYvL0QfNhj/SsVj6nodPaNZp8r8JUV3boc+9FznrKMBN9b
0i3MgymIaFkeUoaIygZykcUFTZ6FuGG35d4mUY5zlZ141lrD9FTnmf7Og4tqKqSj
Q2mHr928Q9MPvZmusStIWepECY71pAYzyeoZ1SlTe0AV9K9LH/TK2GsowGGHOljz
1lQd98Ki+zQzlRX5Cqkwf7Mwejx5gIU/Uy38YUZO7QDNFJU/mnHLZQe969ru0hb6
dgn+w4PLHPoCXOb7giLLCdIDn7ksvailC06OAxwsrAHwtEMzNZbwmJhbk2EROZWH
3EdxJ4O0lzV6lnev8aUgbp8YvlJPUo/ncjnZHEEwcoDfqc2IUjs323O/FrosAj/Y
9HrqfPbjc52HsJecbtpfR5V6lT4BAafj/w82VzIaMXKUSsdgFKwQd9iDKQikGobJ
EKd2qrKv2/dxgPiNb+QSIXhbTY4AGIVSqQ80wFNNdIh33rdL3+9J2CAm+w+H0bJA
jfOgtIKYJeJxHL4xibWs3O+WyMFUQm2R13hT3f5TfDSRMRCWK4g=
=7E8U
-----END PGP SIGNATURE-----
--qw2kmjdrrqrgvxvq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200824114500.7ve4g5j4sikly5ek>