Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jan 2011 19:26:04 +0200
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Ben Kaduk <minimarmot@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r217097 - in head/sys: amd64/include arm/include i386/include ia64/include mips/include powerpc/include sparc64/include sun4v/include
Message-ID:  <20110107172604.GC12599@deviant.kiev.zoral.com.ua>
In-Reply-To: <AANLkTinXfzA4wxWJ5X0i_0dHx7Gag2dAfE0CZgP9D7gh@mail.gmail.com>
References:  <201101071422.p07EMYlP055071@svn.freebsd.org> <AANLkTinXfzA4wxWJ5X0i_0dHx7Gag2dAfE0CZgP9D7gh@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--nG7dHWd/DOCuxGWF
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 07, 2011 at 12:02:55PM -0500, Ben Kaduk wrote:
> On Fri, Jan 7, 2011 at 9:22 AM, Konstantin Belousov <kib@freebsd.org> wro=
te:
> > Author: kib
> > Date: Fri Jan =9A7 14:22:34 2011
> > New Revision: 217097
> > URL: http://svn.freebsd.org/changeset/base/217097
> >
> > Log:
> > =9AAdd AT_STACKPROT elf aux vector. Will be used to inform rtld about t=
he
> > =9Ainitial stack protection set by the kernel image activator.
> >
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> > --- head/sys/amd64/include/elf.h =9A =9A =9A =9AFri Jan =9A7 14:17:29 2=
011 =9A =9A =9A =9A(r217096)
> > +++ head/sys/amd64/include/elf.h =9A =9A =9A =9AFri Jan =9A7 14:22:34 2=
011 =9A =9A =9A =9A(r217097)
> > @@ -94,8 +94,9 @@ __ElfType(Auxinfo);
> > =9A#define =9A =9A =9A =9AAT_NCPUS =9A =9A =9A =9A19 =9A =9A =9A/* Numb=
er of CPUs. */
> > =9A#define =9A =9A =9A =9AAT_PAGESIZES =9A =9A20 =9A =9A =9A/* Pagesize=
s. */
> > =9A#define =9A =9A =9A =9AAT_PAGESIZESLEN 21 =9A =9A =9A/* Number of pa=
gesizes. */
> > +#define =9A =9A =9A =9AAT_STACKPROT =9A =9A23 =9A =9A =9A/* Initial st=
ack protection. */
> >
> > -#define =9A =9A =9A =9AAT_COUNT =9A =9A =9A =9A22 =9A =9A =9A/* Count =
of defined aux entry types. */
> > +#define =9A =9A =9A =9AAT_COUNT =9A =9A =9A =9A24 =9A =9A =9A/* Count =
of defined aux entry types. */
>=20
>=20
> Is there a reason to skip 22?

Yes, I can swear that I saw the reference that stated that even aux vector
types are used for Elf_Auxinfo.a_un.a_ptr, and odd are for a_val.
I already received a private inquiry about the same issue, probably had
to note this in the commit message.

--nG7dHWd/DOCuxGWF
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)

iEYEARECAAYFAk0nTKsACgkQC3+MBN1Mb4i1RgCg3dyYIrpd6/gjKcqNEAQOZoKD
g/kAoKsfMgou+N9neVYekaMg8c9X/i/L
=Aas4
-----END PGP SIGNATURE-----

--nG7dHWd/DOCuxGWF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110107172604.GC12599>