Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Nov 2020 13:07:45 +0000 (UTC)
From:      "George V. Neville-Neil" <gnn@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r367635 - head/sys/netinet
Message-ID:  <202011131307.0ADD7jTG015300@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gnn
Date: Fri Nov 13 13:07:44 2020
New Revision: 367635
URL: https://svnweb.freebsd.org/changeset/base/367635

Log:
  Followup pointed out by ae@

Modified:
  head/sys/netinet/ip_fastfwd.c

Modified: head/sys/netinet/ip_fastfwd.c
==============================================================================
--- head/sys/netinet/ip_fastfwd.c	Fri Nov 13 09:49:22 2020	(r367634)
+++ head/sys/netinet/ip_fastfwd.c	Fri Nov 13 13:07:44 2020	(r367635)
@@ -118,7 +118,11 @@ ip_redir_alloc(struct mbuf *m, struct nhop_object *nh,
     struct ip *ip, in_addr_t *addr)
 {
 	struct mbuf *mcopy = m_gethdr(M_NOWAIT, m->m_type);
-	if (mcopy != NULL && !m_dup_pkthdr(mcopy, m, M_NOWAIT)) {
+
+	if (mcopy == NULL)
+		return (NULL);
+
+	if (m_dup_pkthdr(mcopy, m, M_NOWAIT) == 0) {
 		/*
 		 * It's probably ok if the pkthdr dup fails (because
 		 * the deep copy of the tag chain failed), but for now



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011131307.0ADD7jTG015300>