Date: Thu, 18 Apr 2002 14:28:29 -0500 From: "Jacques A. Vidrine" <nectar@FreeBSD.org> To: Doug Barton <DougB@FreeBSD.org> Cc: "David E. O'Brien" <obrien@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Tools/scripts patchtool.py Message-ID: <20020418192829.GA25519@madman.nectar.cc> In-Reply-To: <20020418114950.R9140-100000@master.gorean.org> References: <20020418175216.GA24952@madman.nectar.cc> <20020418114950.R9140-100000@master.gorean.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 18, 2002 at 11:50:59AM -0700, Doug Barton wrote: > On Thu, 18 Apr 2002, Jacques A. Vidrine wrote: > > > IMHO there was value in doing it in one consistent, mostly unambiguous > > fashion, even if it wasn't `perfect'. `_' isn't perfect either, IMHO, > > and I'd rather not change just because it is someone's pet peeve. > > One could argue that the :: convention came after some of us had > already started using _, but without making so much noise about it. One could, but I don't think that's the point. My ports repository includes 11,180 patch files. Of these: = 1,032 (over 9%) have `::' in the pathname. = 262 (over 2%) have '_' in the pathname. Many of those in the second bullet are `false positives', in that `_' is used sometimes in the actual distribution pathnames or a `_' was used for some inexplicable reason (e.g. audio/csound/files/patch-main_c). So there are at least four times as many patches which use `::' over `_'. OTOH, that leaves over 88% of the port patch files still using the old convention or not including directory names. We had this same thread some time ago, and we picked a convention and stuck with it [1]. Again, with no compelling reason to change, it is hard to take the suggestion seriously. Cheers, -- Jacques A. Vidrine <n@nectar.cc> http://www.nectar.cc/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se [1] During that discussion, I felt that a port maintainer should manage the patches in any reasonable fashion he likes. However, given no other strong convictions, please follow convention. I still feel the same. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020418192829.GA25519>