Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Dec 2022 02:09:50 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6b574b3ba99a - main - stand/zlib: Document the upstream issue behind NO_DEPRECATED_NON_PROTOTYPE
Message-ID:  <202212060209.2B629ob1053855@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=6b574b3ba99af4ae81d4c619057e737e67523907

commit 6b574b3ba99af4ae81d4c619057e737e67523907
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-12-05 23:55:04 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-12-05 23:59:58 +0000

    stand/zlib: Document the upstream issue behind NO_DEPRECATED_NON_PROTOTYPE
    
    The zlib project has issue https://github.com/madler/zlib/issues/633 to
    document its continued use of old K&R-style function definitions.
    
    Suggested by:           delphij@
    Sponsored by:           Netflix
---
 stand/libsa/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/stand/libsa/Makefile b/stand/libsa/Makefile
index 4eccf0f9b132..8248c4a1ba74 100644
--- a/stand/libsa/Makefile
+++ b/stand/libsa/Makefile
@@ -95,6 +95,8 @@ SRCS+=${i}
 .endfor
 
 # decompression functionality from zlib
+# https://github.com/madler/zlib/issues/633 documents why we suppress deprecated
+# prototype warnings.
 .PATH: ${SRCTOP}/sys/contrib/zlib
 ZLIB_CFLAGS=-DHAVE_MEMCPY -I${SRCTOP}/sys/contrib/zlib ${NO_WDEPRECATED_NON_PROTOTYPE}
 .for i in adler32.c crc32.c infback.c inffast.c inflate.c inftrees.c zutil.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202212060209.2B629ob1053855>