Date: Tue, 6 Dec 2022 02:09:51 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 3cf97e91fac5 - main - Revert "newbus: Change attach failure behavior" Message-ID: <202212060209.2B629pnu053879@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=3cf97e91fac5f53fc0375bc816cc541a8864ffc4 commit 3cf97e91fac5f53fc0375bc816cc541a8864ffc4 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2022-12-05 23:57:58 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2022-12-06 00:00:26 +0000 Revert "newbus: Change attach failure behavior" This reverts commit 68c3f0302106643207dcdfe3b414810e245228e5. There are some weird crashes when KVMs switch caused by this, so revert this commit until they are sorted out. Reported by: cy@ Sponsored by: Netflix --- UPDATING | 2 ++ sys/kern/subr_bus.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/UPDATING b/UPDATING index 099066031b8e..001ec9f6de3a 100644 --- a/UPDATING +++ b/UPDATING @@ -43,6 +43,8 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 14.x IS SLOW: needs to use devctl to re-enable the device, and reprobe it (or set the sysctl/tunable hw.bus.disable_failed_devices=false). + NOTE: This was reverted 20221205 due to unexpected compatibility issues + 20221122: pf no longer accepts 'scrub fragment crop' or 'scrub fragment drop-ovl'. These configurations are no longer automatically reinterpreted as diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c index 6a5ec4efc38d..b9615b033007 100644 --- a/sys/kern/subr_bus.c +++ b/sys/kern/subr_bus.c @@ -69,7 +69,7 @@ SYSCTL_NODE(_hw, OID_AUTO, bus, CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, SYSCTL_ROOT_NODE(OID_AUTO, dev, CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, NULL); -static bool disable_failed_devs = true; +static bool disable_failed_devs = false; SYSCTL_BOOL(_hw_bus, OID_AUTO, disable_failed_devices, CTLFLAG_RWTUN, &disable_failed_devs, 0, "Do not retry attaching devices that return an error from DEVICE_ATTACH the first time");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202212060209.2B629pnu053879>