Date: Fri, 16 Dec 2016 20:53:26 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: "Conrad E. Meyer" <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310138 - head/lib/libc/stdio Message-ID: <8CF1AB9C-83FE-495F-B07C-56F928282512@FreeBSD.org> In-Reply-To: <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net> References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_9E64CCF0-2511-4CCA-A8A1-2942F1648B83 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 16 Dec 2016, at 20:31, Baptiste Daroussin <bapt@FreeBSD.org> wrote: >=20 > On Fri, Dec 16, 2016 at 01:44:51AM +0000, Conrad E. Meyer wrote: >> Author: cem >> Date: Fri Dec 16 01:44:50 2016 >> New Revision: 310138 >> URL: https://svnweb.freebsd.org/changeset/base/310138 >>=20 >> Log: >> vfprintf(3): Add support for kernel %b format >>=20 >> This is a direct port of the kernel %b format. >>=20 >> I'm unclear on if (more) non-portable printf extensions will be a >> problem. I think it's desirable to have userspace formats include = all >> kernel formats, but there may be competing goals I'm not aware of. >>=20 >> Reviewed by: no one, unfortunately >> Sponsored by: Dell EMC Isilon >> Differential Revision: https://reviews.freebsd.org/D8426 >>=20 >=20 > I really don't think it is a good idea, if used in userland it would = be make > more of our code difficult to port elsewhere. Indeed, this is a bad idea. These custom format specifiers should be eliminated, not multiplied. :-) > Other than that, it makes more difficult to use vanilla gcc with out = userland. > and it is adding more complexity to be able to build freebsd from a = non freebsd > system which some people are working on. >=20 > Personnaly I would prefer to see those extensions removed from the = kernel rather > than see them available in userland. Same here. > Can't we use simple helper function instead? Yes, please. Just take the snprintb(3) function from NetBSD: http://netbsd.gw.com/cgi-bin/man-cgi?snprintb+3+NetBSD-current -Dimitry --Apple-Mail=_9E64CCF0-2511-4CCA-A8A1-2942F1648B83 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhURj0ACgkQsF6jCi4glqPQsACfYEFD7dxsHbhI6Fvr43NWNIle AUoAn0cFVTr53CCuI6EszEl8h7SmDclg =h+m2 -----END PGP SIGNATURE----- --Apple-Mail=_9E64CCF0-2511-4CCA-A8A1-2942F1648B83--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8CF1AB9C-83FE-495F-B07C-56F928282512>